DPDK patches and discussions
 help / color / mirror / Atom feed
From: Xiaobo Chi <xiaobo.chi@nokia.com>
To: dev@dpdk.org
Cc: Xiaobo Chi <xiaobo.chi@nokia.com>
Subject: [dpdk-dev] [PATCH v2] vhost: fix eventfd_link.ko insertion failure problem
Date: Wed, 11 Nov 2015 14:57:23 +0800	[thread overview]
Message-ID: <1447225043-15404-1-git-send-email-xiaobo.chi@nokia.com> (raw)
In-Reply-To: <1446789877-11656-1-git-send-email-xiaobo.chi@nokia.com>

Problem:if I firstly insert my kmod_test.ko, then insert eventfd_link.ko,
error will happen with hint " Device or resource busy". This is because
the default minor device number, 0, has been occupied by my kmod_test.ko .

root@distro:~/test$ lsmod
Module                  Size  Used by
kmod_test                927  0
vboxsf                 35930  4
vboxguest             222130  1 vboxsf
microcode              10315  0
autofs4                25051  0
root@distro:~/test$ insmod ./eventfd_link.ko
insmod: ERROR: could not insert module ./eventfd_link.ko: Device or
resource busy

Explanation: For miscdevices, the major device_no is same, so the minor
device_no should be set to ditinguish different misc devices;  if not set
the minor, it may fail while insmod due to the default minor value, 0, has
been used by other miscdevice. MISC_DYNAMIC_MINOR means to let Linux
kernel dynamically assign one minor devide number while loading.

Signed-off-by: Xiaobo Chi <xiaobo.chi@nokia.com>
---
 lib/librte_vhost/eventfd_link/eventfd_link.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_vhost/eventfd_link/eventfd_link.c b/lib/librte_vhost/eventfd_link/eventfd_link.c
index c54a938..4b05b5a 100644
--- a/lib/librte_vhost/eventfd_link/eventfd_link.c
+++ b/lib/librte_vhost/eventfd_link/eventfd_link.c
@@ -249,6 +249,7 @@ static const struct file_operations eventfd_link_fops = {
 
 
 static struct miscdevice eventfd_link_misc = {
+	.minor = MISC_DYNAMIC_MINOR,
 	.name = "eventfd-link",
 	.fops = &eventfd_link_fops,
 };
-- 
1.9.4.msysgit.2

  parent reply	other threads:[~2015-11-11  6:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-06  6:04 [dpdk-dev] [PATCH] vhost: eventfd_link's minor number shall be specified Xiaobo Chi
2015-11-09  4:22 ` Yuanhan Liu
2015-11-09 10:03   ` Chi, Xiaobo (Nokia - CN/Hangzhou)
2015-11-09 10:19     ` Chi, Xiaobo (Nokia - CN/Hangzhou)
2015-11-09 12:58       ` Yuanhan Liu
2015-11-10  2:24         ` Chi, Xiaobo (Nokia - CN/Hangzhou)
2015-11-11  6:57 ` Xiaobo Chi [this message]
2015-11-11  7:07   ` [dpdk-dev] [PATCH v2] vhost: fix eventfd_link.ko insertion failure problem Yuanhan Liu
2015-11-24 18:05     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447225043-15404-1-git-send-email-xiaobo.chi@nokia.com \
    --to=xiaobo.chi@nokia.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).