DPDK patches and discussions
 help / color / mirror / Atom feed
From: Cunming Liang <cunming.liang@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 2/2] igb: fix vfio ioctl SET_IRQS error
Date: Fri, 13 Nov 2015 10:50:27 +0800	[thread overview]
Message-ID: <1447383027-11140-2-git-send-email-cunming.liang@intel.com> (raw)
In-Reply-To: <1447383027-11140-1-git-send-email-cunming.liang@intel.com>

The vector number may change during 'dev_start'. Before enabling a new vector mapping,
it's necessary to disable/unmap the previous setting.

Fixes: fe685de2b1b6 ("igb: fix VF start with PF stopped")

Reported-by: Yong Liu <yong.liu@intel.com>
Signed-off-by: Cunming Liang <cunming.liang@intel.com>
---
 drivers/net/e1000/igb_ethdev.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index 4bf4e52..c61ceab 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -1092,6 +1092,9 @@ eth_igb_start(struct rte_eth_dev *dev)
 
 	PMD_INIT_FUNC_TRACE();
 
+	/* disable uio/vfio intr/eventfd mapping */
+	rte_intr_disable(intr_handle);
+
 	/* Power up the phy. Needed to make the link go Up */
 	e1000_power_up_phy(hw);
 
-- 
2.4.3

  reply	other threads:[~2015-11-13  2:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-13  2:50 [dpdk-dev] [PATCH 1/2] ixgbe: " Cunming Liang
2015-11-13  2:50 ` Cunming Liang [this message]
2015-11-17  2:31   ` [dpdk-dev] [PATCH 2/2] igb: " Lu, Wenzhuo
2015-11-24 13:39     ` Thomas Monjalon
2015-11-13  6:08 ` [dpdk-dev] [PATCH 1/2] ixgbe: " Liu, Yong
2015-11-17  2:32   ` Lu, Wenzhuo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447383027-11140-2-git-send-email-cunming.liang@intel.com \
    --to=cunming.liang@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).