From: Zhihong Wang <zhihong.wang@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [RFC PATCH 2/2] lib/librte_eal: Remove unnecessary hugepage zero-filling
Date: Tue, 17 Nov 2015 22:27:11 -0500 [thread overview]
Message-ID: <1447817231-10510-3-git-send-email-zhihong.wang@intel.com> (raw)
In-Reply-To: <1447817231-10510-1-git-send-email-zhihong.wang@intel.com>
The kernel fills new allocated (huge) pages with zeros.
DPDK just has to touch the pages to trigger the allocation.
Signed-off-by: Zhihong Wang <zhihong.wang@intel.com>
---
lib/librte_eal/linuxapp/eal/eal_memory.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c
index 0de75cd..af823dc 100644
--- a/lib/librte_eal/linuxapp/eal/eal_memory.c
+++ b/lib/librte_eal/linuxapp/eal/eal_memory.c
@@ -410,7 +410,7 @@ map_all_hugepages(struct hugepage_file *hugepg_tbl,
if (orig) {
hugepg_tbl[i].orig_va = virtaddr;
- memset(virtaddr, 0, hugepage_sz);
+ memset(virtaddr, 0, 8);
}
else {
hugepg_tbl[i].final_va = virtaddr;
@@ -592,9 +592,6 @@ remap_all_hugepages(struct hugepage_file *hugepg_tbl, struct hugepage_info *hpi)
}
}
- /* zero out the whole segment */
- memset(hugepg_tbl[page_idx].final_va, 0, total_size);
-
page_idx++;
}
--
2.5.0
next prev parent reply other threads:[~2015-11-18 10:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 3:27 [dpdk-dev] [RFC PATCH 0/2] Reduce DPDK initialization time Zhihong Wang
2015-11-18 3:27 ` [dpdk-dev] [RFC PATCH 1/2] lib/librte_eal: Reduce timer " Zhihong Wang
2015-11-18 3:27 ` Zhihong Wang [this message]
2015-11-18 10:39 ` [dpdk-dev] [RFC PATCH 2/2] lib/librte_eal: Remove unnecessary hugepage zero-filling Mcnamara, John
2015-11-18 10:44 ` Wang, Zhihong
2015-11-18 12:07 ` Xie, Huawei
2015-11-18 16:00 ` Stephen Hemminger
2015-11-18 16:13 ` Richardson, Bruce
2015-11-18 19:09 ` Stephen Hemminger
2015-11-19 2:15 ` Wang, Zhihong
2015-11-19 6:04 ` Xie, Huawei
2015-11-19 6:32 ` Wang, Zhihong
2015-11-19 9:18 ` Sergio Gonzalez Monroy
2015-11-23 2:54 ` Xie, Huawei
2015-11-23 10:18 ` Bruce Richardson
2015-11-20 12:15 ` Bruce Richardson
2015-11-19 3:54 ` Wang, Zhihong
2015-11-19 6:09 ` Xie, Huawei
2015-11-19 9:14 ` Sergio Gonzalez Monroy
2015-11-23 3:46 ` Xie, Huawei
2015-11-23 4:07 ` Stephen Hemminger
2015-11-23 5:05 ` Xie, Huawei
2015-11-23 6:52 ` Stephen Hemminger
2015-11-25 18:24 ` Xie, Huawei
2015-12-24 8:34 ` [dpdk-dev] [RFC PATCH 0/2] Reduce DPDK initialization time Qiu, Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447817231-10510-3-git-send-email-zhihong.wang@intel.com \
--to=zhihong.wang@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).