From: Mauricio Vasquez B <mauricio.vasquezbernal@studenti.polito.it>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] ring: Fix memory leakage in rte_pmd_ring_devuninit
Date: Fri, 20 Nov 2015 19:24:19 +0100 [thread overview]
Message-ID: <1448043859-4326-1-git-send-email-mauricio.vasquezbernal@studenti.polito.it> (raw)
In-Reply-To: <1447885757-13038-1-git-send-email-mauricio.vasquezbernal@studenti.polito.it>
When freeing the device it is also neccesary to free
rx_queues and tx_queues
Signed-off-by: Mauricio Vasquez B <mauricio.vasquezbernal@studenti.polito.it>
---
v2:
Added extra control before freeing members of eth_dev->data
drivers/net/ring/rte_eth_ring.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
index 9a31bce..4ce0256 100644
--- a/drivers/net/ring/rte_eth_ring.c
+++ b/drivers/net/ring/rte_eth_ring.c
@@ -582,7 +582,12 @@ rte_pmd_ring_devuninit(const char *name)
return -ENODEV;
eth_dev_stop(eth_dev);
- rte_free(eth_dev->data->dev_private);
+
+ if(eth_dev->data) {
+ rte_free(eth_dev->data->rx_queues);
+ rte_free(eth_dev->data->tx_queues);
+ rte_free(eth_dev->data->dev_private);
+ }
rte_free(eth_dev->data);
rte_eth_dev_release_port(eth_dev);
--
1.9.1
next prev parent reply other threads:[~2015-11-20 18:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 22:29 [dpdk-dev] [PATCH] ring: Fix memory leakage in rte_pmd_ring_devuninit() Mauricio Vasquez B
2015-11-20 12:20 ` Iremonger, Bernard
2015-11-20 12:32 ` Mcnamara, John
2015-11-20 12:42 ` Richardson, Bruce
2015-11-20 18:22 ` Mauricio Vásquez
2015-11-20 18:24 ` Mauricio Vasquez B [this message]
2015-11-23 22:47 ` [dpdk-dev] [PATCH] ring: Fix memory leakage in rte_pmd_ring_devuninit Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448043859-4326-1-git-send-email-mauricio.vasquezbernal@studenti.polito.it \
--to=mauricio.vasquezbernal@studenti.polito.it \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).