From: David Hunt <david.hunt@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] test: fix crash in pmd_perf_test
Date: Mon, 23 Nov 2015 11:45:48 +0000 [thread overview]
Message-ID: <1448279148-14283-1-git-send-email-david.hunt@intel.com> (raw)
Fix crash in pmd_perf_test autotest (div by 0) when no packets received
Also fixes the fact that the test passes even if exec_burst fails
To repeat the issue:
The system must be incorrectly set up so that all packets will be lost,
i.e. no loopback cable, etc. This is an edge case, but still the test
should not crash or pass when failing.
run the test app
RTE>> set_rxtx_sc poll_before_xmit
RTE>> pmd_perf_autotest
--snip--
> Generate 4096 packets @socket 1
> start to receive total expect 4096
> 4096 packets lost, IDLE 10000 times
> Floating point exception (core dumped)
Signed-off-by: David Hunt <david.hunt@intel.com>
---
app/test/test_pmd_perf.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/app/test/test_pmd_perf.c b/app/test/test_pmd_perf.c
index 8f55640..25b4d09 100644
--- a/app/test/test_pmd_perf.c
+++ b/app/test/test_pmd_perf.c
@@ -626,7 +626,10 @@ timeout:
rte_free(pkts_burst);
- return diff_tsc / total;
+ if (total > 0)
+ return diff_tsc / total;
+ else
+ return -1;
}
static int
@@ -673,8 +676,10 @@ exec_burst(uint32_t flags, int lcore)
/* wait for polling finished */
diff_tsc = rte_eal_wait_lcore(lcore);
- if (diff_tsc < 0)
+ if (diff_tsc < 0) {
+ printf("exec_burst: Failed to measure cycles per packet\n");
return -1;
+ }
printf("Result: %d cycles per packet\n", diff_tsc);
@@ -811,7 +816,8 @@ test_pmd_perf(void)
return -1;
} else if (sc_flag == SC_BURST_POLL_FIRST ||
sc_flag == SC_BURST_XMIT_FIRST)
- exec_burst(sc_flag, slave_id);
+ if (exec_burst(sc_flag, slave_id) < 0)
+ return -1;
/* port tear down */
for (portid = 0; portid < nb_ports; portid++) {
--
2.1.0
next reply other threads:[~2015-11-23 11:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 11:45 David Hunt [this message]
2015-12-07 2:41 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448279148-14283-1-git-send-email-david.hunt@intel.com \
--to=david.hunt@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).