From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by dpdk.org (Postfix) with ESMTP id 2BC8E3F9 for ; Wed, 17 Dec 2014 01:13:21 +0100 (CET) Received: by mail-wi0-f179.google.com with SMTP id ex7so14318428wid.6 for ; Tue, 16 Dec 2014 16:13:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=W5j6frdhrk+M5yQXRek0MSvvDsIi3RH+V2642TMGVT4=; b=HZoP1Qkb/RxXuKIL4PmgFxSxs6RFUgoK/mXGtZ44/1pReNWhX3JOeJRoX/DMRdh6CY oJSbyCsTunViAcdwfZupI8q39FJsthez1OwbhMF9vJFJi00PyY04wSRwXmdXoqdsJsPx oAYfJ6UDmUEiw9ejB+afUN7Lb5iTdxh55SEvG0aeg9BijFznwsNpZNRyV2SqCpyf+9Vn tYWju2MbJztir57h3wL+b6tH9qBtscoHZmNtjHf+RHxrx/Bjga3bl0JzcqvjFRSfjSqR R9n4DknhUv5OW2frJNDBkkuF15fkqeSCavcVJT8PalMqeCAd+wbP08t6mcjskJRRgFY0 vWnw== X-Gm-Message-State: ALoCoQmAPRB5MEQ5Iu+vUU4WmakLld1YlS8CTbPsmgIM1uqJ/jGJ+grh1pcDVynRxJA4Ia0raTxG X-Received: by 10.180.19.193 with SMTP id h1mr9092747wie.10.1418775201058; Tue, 16 Dec 2014 16:13:21 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id eu8sm3984250wib.21.2014.12.16.16.13.19 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Dec 2014 16:13:20 -0800 (PST) From: Thomas Monjalon To: Konstantin Ananyev Date: Wed, 17 Dec 2014 01:12:53 +0100 Message-ID: <1448328.g5Olc06rYm@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1418749508-17748-1-git-send-email-konstantin.ananyev@intel.com> References: <1418749508-17748-1-git-send-email-konstantin.ananyev@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] l3fwd-acl: fix possible memory leak. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Dec 2014 00:13:21 -0000 > At error app_acl_init() can return without freeing dynamically allocated memory. > Not really a big problem, as if app_acl_init() fails, > then application would terminate immediately anyway. > Though it is a good coding practise to make a function to cleanup after itself. > > Signed-off-by: Konstantin Ananyev Applied Thanks -- Thomas