* [dpdk-dev] [PATCH] fm10k: add debug info for actual Rx/Tx func
@ 2015-11-24 6:00 Chen Jing D(Mark)
2015-11-24 10:32 ` Thomas Monjalon
2015-11-27 1:54 ` [dpdk-dev] [PATCH v2] " Chen Jing D(Mark)
0 siblings, 2 replies; 6+ messages in thread
From: Chen Jing D(Mark) @ 2015-11-24 6:00 UTC (permalink / raw)
To: dev
From: "Chen Jing D(Mark)" <jing.d.chen@intel.com>
After introducing vPMD feature, fm10k driver will select best
Rx/Tx in running time. Original implementation selects Rx/Tx
silently without notifications.
This patch adds debug info to notify user what actual Rx/Tx
func are used.
Signed-off-by: Chen Jing D(Mark) <jing.d.chen@intel.com>
---
drivers/net/fm10k/fm10k_ethdev.c | 10 +++++++++-
1 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c
index 7f5c852..34dd55c 100644
--- a/drivers/net/fm10k/fm10k_ethdev.c
+++ b/drivers/net/fm10k/fm10k_ethdev.c
@@ -2402,13 +2402,16 @@ fm10k_set_tx_function(struct rte_eth_dev *dev)
}
if (use_sse) {
+ PMD_INIT_LOG(ERR, "Use vector Tx func");
for (i = 0; i < dev->data->nb_tx_queues; i++) {
txq = dev->data->tx_queues[i];
fm10k_txq_vec_setup(txq);
}
dev->tx_pkt_burst = fm10k_xmit_pkts_vec;
- } else
+ } else {
dev->tx_pkt_burst = fm10k_xmit_pkts;
+ PMD_INIT_LOG(ERR, "Use regular Tx func");
+ }
}
static void __attribute__((cold))
@@ -2432,6 +2435,11 @@ fm10k_set_rx_function(struct rte_eth_dev *dev)
(dev->rx_pkt_burst == fm10k_recv_scattered_pkts_vec ||
dev->rx_pkt_burst == fm10k_recv_pkts_vec);
+ if (rx_using_sse)
+ PMD_INIT_LOG(ERR, "Use vector Rx func");
+ else
+ PMD_INIT_LOG(ERR, "Use regular Rx func");
+
for (i = 0; i < dev->data->nb_rx_queues; i++) {
struct fm10k_rx_queue *rxq = dev->data->rx_queues[i];
--
1.7.7.6
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] fm10k: add debug info for actual Rx/Tx func
2015-11-24 6:00 [dpdk-dev] [PATCH] fm10k: add debug info for actual Rx/Tx func Chen Jing D(Mark)
@ 2015-11-24 10:32 ` Thomas Monjalon
2015-11-24 16:41 ` Stephen Hemminger
2015-11-27 1:54 ` [dpdk-dev] [PATCH v2] " Chen Jing D(Mark)
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2015-11-24 10:32 UTC (permalink / raw)
To: Chen Jing D(Mark); +Cc: dev
2015-11-24 14:00, Chen Jing D:
> This patch adds debug info to notify user what actual Rx/Tx
> func are used.
[...]
> + if (rx_using_sse)
> + PMD_INIT_LOG(ERR, "Use vector Rx func");
> + else
> + PMD_INIT_LOG(ERR, "Use regular Rx func");
debug info != LOG(ERR
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] fm10k: add debug info for actual Rx/Tx func
2015-11-24 10:32 ` Thomas Monjalon
@ 2015-11-24 16:41 ` Stephen Hemminger
2015-11-25 8:47 ` Chen, Jing D
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Hemminger @ 2015-11-24 16:41 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev
On Tue, 24 Nov 2015 11:32:46 +0100
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> 2015-11-24 14:00, Chen Jing D:
> > This patch adds debug info to notify user what actual Rx/Tx
> > func are used.
> [...]
> > + if (rx_using_sse)
> > + PMD_INIT_LOG(ERR, "Use vector Rx func");
> > + else
> > + PMD_INIT_LOG(ERR, "Use regular Rx func");
>
> debug info != LOG(ERR
Really should be DEBUG.
Developers need to remember you don't wan to see those log messages
in a production system.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] fm10k: add debug info for actual Rx/Tx func
2015-11-24 16:41 ` Stephen Hemminger
@ 2015-11-25 8:47 ` Chen, Jing D
0 siblings, 0 replies; 6+ messages in thread
From: Chen, Jing D @ 2015-11-25 8:47 UTC (permalink / raw)
To: Stephen Hemminger, Thomas Monjalon; +Cc: dev
> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Wednesday, November 25, 2015 12:42 AM
> To: Thomas Monjalon
> Cc: Chen, Jing D; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] fm10k: add debug info for actual Rx/Tx func
>
> On Tue, 24 Nov 2015 11:32:46 +0100
> Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
>
> > 2015-11-24 14:00, Chen Jing D:
> > > This patch adds debug info to notify user what actual Rx/Tx
> > > func are used.
> > [...]
> > > + if (rx_using_sse)
> > > + PMD_INIT_LOG(ERR, "Use vector Rx func");
> > > + else
> > > + PMD_INIT_LOG(ERR, "Use regular Rx func");
> >
> > debug info != LOG(ERR
>
> Really should be DEBUG.
> Developers need to remember you don't wan to see those log messages
> in a production system.
Thanks for the comments. I'll change accordingly.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2] fm10k: add debug info for actual Rx/Tx func
2015-11-24 6:00 [dpdk-dev] [PATCH] fm10k: add debug info for actual Rx/Tx func Chen Jing D(Mark)
2015-11-24 10:32 ` Thomas Monjalon
@ 2015-11-27 1:54 ` Chen Jing D(Mark)
2015-11-27 18:53 ` Thomas Monjalon
1 sibling, 1 reply; 6+ messages in thread
From: Chen Jing D(Mark) @ 2015-11-27 1:54 UTC (permalink / raw)
To: dev
From: "Chen Jing D(Mark)" <jing.d.chen@intel.com>
After introducing vPMD feature, fm10k driver will select best
Rx/Tx in running time. Original implementation selects Rx/Tx
silently without notifications.
This patch adds debug info to notify user what actual Rx/Tx
func are used.
Signed-off-by: Chen Jing D(Mark) <jing.d.chen@intel.com>
---
drivers/net/fm10k/fm10k_ethdev.c | 10 +++++++++-
1 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c
index 0dd56d2..4f23ce3 100644
--- a/drivers/net/fm10k/fm10k_ethdev.c
+++ b/drivers/net/fm10k/fm10k_ethdev.c
@@ -2458,13 +2458,16 @@ fm10k_set_tx_function(struct rte_eth_dev *dev)
}
if (use_sse) {
+ PMD_INIT_LOG(DEBUG, "Use vector Tx func");
for (i = 0; i < dev->data->nb_tx_queues; i++) {
txq = dev->data->tx_queues[i];
fm10k_txq_vec_setup(txq);
}
dev->tx_pkt_burst = fm10k_xmit_pkts_vec;
- } else
+ } else {
dev->tx_pkt_burst = fm10k_xmit_pkts;
+ PMD_INIT_LOG(DEBUG, "Use regular Tx func");
+ }
}
static void __attribute__((cold))
@@ -2488,6 +2491,11 @@ fm10k_set_rx_function(struct rte_eth_dev *dev)
(dev->rx_pkt_burst == fm10k_recv_scattered_pkts_vec ||
dev->rx_pkt_burst == fm10k_recv_pkts_vec);
+ if (rx_using_sse)
+ PMD_INIT_LOG(DEBUG, "Use vector Rx func");
+ else
+ PMD_INIT_LOG(DEBUG, "Use regular Rx func");
+
for (i = 0; i < dev->data->nb_rx_queues; i++) {
struct fm10k_rx_queue *rxq = dev->data->rx_queues[i];
--
1.7.7.6
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH v2] fm10k: add debug info for actual Rx/Tx func
2015-11-27 1:54 ` [dpdk-dev] [PATCH v2] " Chen Jing D(Mark)
@ 2015-11-27 18:53 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2015-11-27 18:53 UTC (permalink / raw)
To: Chen Jing D(Mark); +Cc: dev
2015-11-27 09:54, Chen Jing D:
> From: "Chen Jing D(Mark)" <jing.d.chen@intel.com>
>
> After introducing vPMD feature, fm10k driver will select best
> Rx/Tx in running time. Original implementation selects Rx/Tx
> silently without notifications.
>
> This patch adds debug info to notify user what actual Rx/Tx
> func are used.
>
> Signed-off-by: Chen Jing D(Mark) <jing.d.chen@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-11-27 18:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-24 6:00 [dpdk-dev] [PATCH] fm10k: add debug info for actual Rx/Tx func Chen Jing D(Mark)
2015-11-24 10:32 ` Thomas Monjalon
2015-11-24 16:41 ` Stephen Hemminger
2015-11-25 8:47 ` Chen, Jing D
2015-11-27 1:54 ` [dpdk-dev] [PATCH v2] " Chen Jing D(Mark)
2015-11-27 18:53 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).