DPDK patches and discussions
 help / color / mirror / Atom feed
From: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v2] net: fix build with gcc 4.4.7 and strict aliasing
Date: Tue, 24 Nov 2015 17:31:18 +0100	[thread overview]
Message-ID: <1448382678-6060-2-git-send-email-danielx.t.mrzyglod@intel.com> (raw)
In-Reply-To: <1448382678-6060-1-git-send-email-danielx.t.mrzyglod@intel.com>

This fix is for IPv6 checksum offload error on RHEL65.
Any optimalisation above -O0 provide error in IPv6 checksum
flag "-fstrict-aliasing" is default for optimalisation above -O0.

Fixes: 2b039d5f20a3 ("net: fix build with gcc 4.4.7 and strict aliasing")

Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
---
 lib/librte_net/rte_ip.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h
index 71c519a..5b7554a 100644
--- a/lib/librte_net/rte_ip.h
+++ b/lib/librte_net/rte_ip.h
@@ -169,7 +169,8 @@ __rte_raw_cksum(const void *buf, size_t len, uint32_t sum)
 {
 	/* workaround gcc strict-aliasing warning */
 	uintptr_t ptr = (uintptr_t)buf;
-	const uint16_t *u16 = (const uint16_t *)ptr;
+	typedef uint16_t __attribute__((__may_alias__)) u16_p;
+	const u16_p *u16 = (const u16_p *)ptr;
 
 	while (len >= (sizeof(*u16) * 4)) {
 		sum += u16[0];
-- 
2.5.0

  reply	other threads:[~2015-11-24 16:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-24 15:12 [dpdk-dev] [PATCH] " Daniel Mrzyglod
2015-11-24 15:47 ` Mrzyglod, DanielX T
2015-11-24 15:49   ` Bruce Richardson
2015-11-24 16:31 ` [dpdk-dev] [PATCH v2] " Daniel Mrzyglod
2015-11-24 16:31   ` Daniel Mrzyglod [this message]
2015-11-24 17:58     ` Ananyev, Konstantin
2015-11-25 17:06       ` Mrzyglod, DanielX T
2015-11-25 17:13         ` Ananyev, Konstantin
2015-11-24 22:42   ` Stephen Hemminger
2015-11-25 18:00 ` [dpdk-dev] [PATCH] " Ananyev, Konstantin
2015-11-25 20:58   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1448382678-6060-2-git-send-email-danielx.t.mrzyglod@intel.com \
    --to=danielx.t.mrzyglod@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).