From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 3AF8C8E8A for ; Tue, 24 Nov 2015 18:38:08 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP; 24 Nov 2015 09:38:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,339,1444719600"; d="scan'208";a="1666651" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by fmsmga004.fm.intel.com with ESMTP; 24 Nov 2015 09:38:06 -0800 Received: from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com [10.237.217.45]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id tAOHc5mh016972; Tue, 24 Nov 2015 17:38:05 GMT Received: from sivswdev01.ir.intel.com (localhost [127.0.0.1]) by sivswdev01.ir.intel.com with ESMTP id tAOHc5Ui001526; Tue, 24 Nov 2015 17:38:05 GMT Received: (from bricha3@localhost) by sivswdev01.ir.intel.com with id tAOHc5ZB001522; Tue, 24 Nov 2015 17:38:05 GMT From: Bruce Richardson To: dev@dpdk.org Date: Tue, 24 Nov 2015 17:37:55 +0000 Message-Id: <1448386677-1441-1-git-send-email-bruce.richardson@intel.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1447762867-32124-1-git-send-email-bruce.richardson@intel.com> References: <1447762867-32124-1-git-send-email-bruce.richardson@intel.com> Subject: [dpdk-dev] [PATCH v5 0/2] ethdev: debug code cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Nov 2015 17:38:09 -0000 This patchset performs two cleanups: 1. Four functions in ethdev.c which were enabled for debug only have been merged into their inlined header-file counterparts. This change required that a number of macros be renamed and moved to the header file too. The macro changes are in patches 1 & 2, and the elimination of the separate debug fns are in patch 3. 2. Checks for valid function pointers are added to the API calls for reading the descriptor ring count, and checking for a valid descriptor. This is because these functions are not implemented by most drivers, and so it's far safer to have the check. NOTE: This patchset now depends upon the cryptodev patchset --- V5 Changes: * Remove the 4 debug functions from the map file and, as a result of this, move all previous functions to the new 2_2 version, sorting them alphabetically. * Update release notes to cover ABI change * Update release notes to cover API change for the rx_count() function V4 Changes: * Originally this was a 4-patch set, but patches 1 and 2 duplicated changes being made in the patchset to add crypto device support. Therefore this set has been reduced to two patches to sit on top of that set. * As suggested on-list, when adding checks for the function pointers being valid we can also add in the similarly lightweight checks for the port id being valid. V3 Changes: * Rebased to latest DPDK codebase * Fixed checkpatch issues in patches 2 and 3. V2 Changes: * Rebased to latest DPDK codebase * Changed type from uint32_t to int for the count function, on the basis of feedback received. Bruce Richardson (2): ethdev: remove duplicated debug functions ethdev: add sanity checks to functions doc/guides/rel_notes/release_2_2.rst | 7 ++++ lib/librte_ether/rte_ethdev.c | 64 --------------------------------- lib/librte_ether/rte_ethdev.h | 62 ++++++++++++++++---------------- lib/librte_ether/rte_ether_version.map | 66 +++++++++++++--------------------- 4 files changed, 61 insertions(+), 138 deletions(-) -- 2.5.0