* [dpdk-dev] [PATCH] examples/bond: fix bsd compile error
@ 2015-11-25 17:36 Ferruh Yigit
2015-11-25 17:41 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2015-11-25 17:36 UTC (permalink / raw)
To: dev
Error:
== bond
CC main.o
/.../examples/bond/main.c:431:24: error: use of undeclared identifier 'AF_INET'
if (res->ip.family == AF_INET)
^
1 error generated.
/.../mk/internal/rte.compile-pre.mk:126: recipe for target 'main.o' failed
AF_INET defined in sys/socket.h
This header included for Linux:
. /<snip>/include/rte_ip.h
.. /usr/include/netinet/in.h
... /usr/include/sys/socket.h
But not for FreeBSD:
. /<snip>/include/rte_ip.h
.. /usr/include/netinet/in.h
... /usr/include/machine/endian.h
... /usr/include/netinet6/in6.h
. /<snip>/include/rte_tcp.h
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
examples/bond/main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/examples/bond/main.c b/examples/bond/main.c
index 4622283..b2d5ac2 100644
--- a/examples/bond/main.c
+++ b/examples/bond/main.c
@@ -75,6 +75,7 @@
#include <rte_tcp.h>
#include <rte_arp.h>
#include <rte_spinlock.h>
+#include <sys/socket.h>
#include <cmdline_rdline.h>
#include <cmdline_parse.h>
--
2.5.0
^ permalink raw reply [flat|nested] 4+ messages in thread* [dpdk-dev] [PATCH v2] examples/bond: fix bsd compile error
2015-11-25 17:36 [dpdk-dev] [PATCH] examples/bond: fix bsd compile error Ferruh Yigit
@ 2015-11-25 17:41 ` Ferruh Yigit
2015-11-26 9:52 ` Mrzyglod, DanielX T
0 siblings, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2015-11-25 17:41 UTC (permalink / raw)
To: dev
Error:
== bond
CC main.o
/.../examples/bond/main.c:431:24: error: use of undeclared identifier 'AF_INET'
if (res->ip.family == AF_INET)
^
1 error generated.
/.../mk/internal/rte.compile-pre.mk:126: recipe for target 'main.o' failed
AF_INET defined in sys/socket.h
This header included for Linux:
. /<snip>/include/rte_ip.h
.. /usr/include/netinet/in.h
... /usr/include/sys/socket.h
But not for FreeBSD:
. /<snip>/include/rte_ip.h
.. /usr/include/netinet/in.h
... /usr/include/machine/endian.h
... /usr/include/netinet6/in6.h
. /<snip>/include/rte_tcp.h
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
examples/bond/main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/examples/bond/main.c b/examples/bond/main.c
index 4622283..19f4f05 100644
--- a/examples/bond/main.c
+++ b/examples/bond/main.c
@@ -45,6 +45,7 @@
#include <termios.h>
#include <unistd.h>
#include <pthread.h>
+#include <sys/socket.h>
#include <rte_common.h>
#include <rte_log.h>
--
2.5.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH v2] examples/bond: fix bsd compile error
2015-11-25 17:41 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
@ 2015-11-26 9:52 ` Mrzyglod, DanielX T
2015-12-02 10:55 ` Yigit, Ferruh
0 siblings, 1 reply; 4+ messages in thread
From: Mrzyglod, DanielX T @ 2015-11-26 9:52 UTC (permalink / raw)
To: Yigit, Ferruh, dev
>-----Original Message-----
>From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit
>Sent: Wednesday, November 25, 2015 6:41 PM
>To: dev@dpdk.org
>Subject: [dpdk-dev] [PATCH v2] examples/bond: fix bsd compile error
>
>Error:
>== bond
> CC main.o
>/.../examples/bond/main.c:431:24: error: use of undeclared identifier 'AF_INET'
> if (res->ip.family == AF_INET)
> ^
>1 error generated.
>/.../mk/internal/rte.compile-pre.mk:126: recipe for target 'main.o' failed
>
>AF_INET defined in sys/socket.h
>
>This header included for Linux:
>. /<snip>/include/rte_ip.h
>.. /usr/include/netinet/in.h
>... /usr/include/sys/socket.h
>
>But not for FreeBSD:
>. /<snip>/include/rte_ip.h
>.. /usr/include/netinet/in.h
>... /usr/include/machine/endian.h
>... /usr/include/netinet6/in6.h
>. /<snip>/include/rte_tcp.h
>
>Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>---
> examples/bond/main.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/examples/bond/main.c b/examples/bond/main.c
>index 4622283..19f4f05 100644
>--- a/examples/bond/main.c
>+++ b/examples/bond/main.c
>@@ -45,6 +45,7 @@
> #include <termios.h>
> #include <unistd.h>
> #include <pthread.h>
>+#include <sys/socket.h>
>
> #include <rte_common.h>
> #include <rte_log.h>
>--
>2.5.0
Acked-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH v2] examples/bond: fix bsd compile error
2015-11-26 9:52 ` Mrzyglod, DanielX T
@ 2015-12-02 10:55 ` Yigit, Ferruh
0 siblings, 0 replies; 4+ messages in thread
From: Yigit, Ferruh @ 2015-12-02 10:55 UTC (permalink / raw)
To: Mrzyglod, DanielX T; +Cc: dev
On Thu, Nov 26, 2015 at 09:52:15AM +0000, Mrzyglod, DanielX T wrote:
> >-----Original Message-----
> >From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit
> >Sent: Wednesday, November 25, 2015 6:41 PM
> >To: dev@dpdk.org
> >Subject: [dpdk-dev] [PATCH v2] examples/bond: fix bsd compile error
> >
> >Error:
> >== bond
> > CC main.o
> >/.../examples/bond/main.c:431:24: error: use of undeclared identifier 'AF_INET'
> > if (res->ip.family == AF_INET)
> > ^
> >1 error generated.
> >/.../mk/internal/rte.compile-pre.mk:126: recipe for target 'main.o' failed
> >
> >AF_INET defined in sys/socket.h
> >
> >This header included for Linux:
> >. /<snip>/include/rte_ip.h
> >.. /usr/include/netinet/in.h
> >... /usr/include/sys/socket.h
> >
> >But not for FreeBSD:
> >. /<snip>/include/rte_ip.h
> >.. /usr/include/netinet/in.h
> >... /usr/include/machine/endian.h
> >... /usr/include/netinet6/in6.h
> >. /<snip>/include/rte_tcp.h
> >
> >Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >---
> > examples/bond/main.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >diff --git a/examples/bond/main.c b/examples/bond/main.c
> >index 4622283..19f4f05 100644
> >--- a/examples/bond/main.c
> >+++ b/examples/bond/main.c
> >@@ -45,6 +45,7 @@
> > #include <termios.h>
> > #include <unistd.h>
> > #include <pthread.h>
> >+#include <sys/socket.h>
> >
> > #include <rte_common.h>
> > #include <rte_log.h>
> >--
> >2.5.0
>
> Acked-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
Self NACK, in favour of http://dpdk.org/dev/patchwork/patch/9130/
I will update pathwork.
Thanks,
ferruh
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-02 10:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-25 17:36 [dpdk-dev] [PATCH] examples/bond: fix bsd compile error Ferruh Yigit
2015-11-25 17:41 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2015-11-26 9:52 ` Mrzyglod, DanielX T
2015-12-02 10:55 ` Yigit, Ferruh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).