DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] config: disable CONFIG_RTE_SCHED_VECTOR for arm
@ 2015-11-27  9:53 Jerin Jacob
  2015-11-27 10:23 ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Jerin Jacob @ 2015-11-27  9:53 UTC (permalink / raw)
  To: dev

Commit 42ec27a0178a causes compiling error on arm, as RTE_SCHED_VECTOR
does support only SSE intrinsic, so disable it till we have neon support.

Fixes: 42ec27a0178a ("sched: enable SSE optimizations in config")

Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
 config/defconfig_arm-armv7a-linuxapp-gcc     | 1 +
 config/defconfig_arm64-armv8a-linuxapp-gcc   | 1 +
 config/defconfig_arm64-thunderx-linuxapp-gcc | 1 +
 config/defconfig_arm64-xgene1-linuxapp-gcc   | 1 +
 4 files changed, 4 insertions(+)

diff --git a/config/defconfig_arm-armv7a-linuxapp-gcc b/config/defconfig_arm-armv7a-linuxapp-gcc
index 82143af..9924ff9 100644
--- a/config/defconfig_arm-armv7a-linuxapp-gcc
+++ b/config/defconfig_arm-armv7a-linuxapp-gcc
@@ -57,6 +57,7 @@ CONFIG_RTE_LIBRTE_ACL=n
 CONFIG_RTE_LIBRTE_LPM=n
 CONFIG_RTE_LIBRTE_TABLE=n
 CONFIG_RTE_LIBRTE_PIPELINE=n
+CONFIG_RTE_SCHED_VECTOR=n
 
 # cannot use those on ARM
 CONFIG_RTE_KNI_KMOD=n
diff --git a/config/defconfig_arm64-armv8a-linuxapp-gcc b/config/defconfig_arm64-armv8a-linuxapp-gcc
index 49e7056..504f3ed 100644
--- a/config/defconfig_arm64-armv8a-linuxapp-gcc
+++ b/config/defconfig_arm64-armv8a-linuxapp-gcc
@@ -54,3 +54,4 @@ CONFIG_RTE_LIBRTE_I40E_PMD=n
 CONFIG_RTE_LIBRTE_LPM=n
 CONFIG_RTE_LIBRTE_TABLE=n
 CONFIG_RTE_LIBRTE_PIPELINE=n
+CONFIG_RTE_SCHED_VECTOR=n
diff --git a/config/defconfig_arm64-thunderx-linuxapp-gcc b/config/defconfig_arm64-thunderx-linuxapp-gcc
index 6b2048b..8b10310 100644
--- a/config/defconfig_arm64-thunderx-linuxapp-gcc
+++ b/config/defconfig_arm64-thunderx-linuxapp-gcc
@@ -54,3 +54,4 @@ CONFIG_RTE_LIBRTE_I40E_PMD=n
 CONFIG_RTE_LIBRTE_LPM=n
 CONFIG_RTE_LIBRTE_TABLE=n
 CONFIG_RTE_LIBRTE_PIPELINE=n
+CONFIG_RTE_SCHED_VECTOR=n
diff --git a/config/defconfig_arm64-xgene1-linuxapp-gcc b/config/defconfig_arm64-xgene1-linuxapp-gcc
index d75f8f0..7f72d01 100644
--- a/config/defconfig_arm64-xgene1-linuxapp-gcc
+++ b/config/defconfig_arm64-xgene1-linuxapp-gcc
@@ -54,3 +54,4 @@ CONFIG_RTE_LIBRTE_I40E_PMD=n
 CONFIG_RTE_LIBRTE_LPM=n
 CONFIG_RTE_LIBRTE_TABLE=n
 CONFIG_RTE_LIBRTE_PIPELINE=n
+CONFIG_RTE_SCHED_VECTOR=n
-- 
2.1.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] config: disable CONFIG_RTE_SCHED_VECTOR for arm
  2015-11-27  9:53 [dpdk-dev] [PATCH] config: disable CONFIG_RTE_SCHED_VECTOR for arm Jerin Jacob
@ 2015-11-27 10:23 ` Thomas Monjalon
  2015-11-27 10:50   ` Jerin Jacob
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2015-11-27 10:23 UTC (permalink / raw)
  To: Jerin Jacob; +Cc: dev

Hi Jerin,

2015-11-27 15:23, Jerin Jacob:
> Commit 42ec27a0178a causes compiling error on arm, as RTE_SCHED_VECTOR
> does support only SSE intrinsic, so disable it till we have neon support.
> 
> Fixes: 42ec27a0178a ("sched: enable SSE optimizations in config")
> 
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
>  config/defconfig_arm-armv7a-linuxapp-gcc     | 1 +
>  config/defconfig_arm64-armv8a-linuxapp-gcc   | 1 +
>  config/defconfig_arm64-thunderx-linuxapp-gcc | 1 +
>  config/defconfig_arm64-xgene1-linuxapp-gcc   | 1 +

You would not need to update 4 files if the 3 last ones were including the
first one.
I think having an arm config base would also make clearer the differences
between the arm platforms.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] config: disable CONFIG_RTE_SCHED_VECTOR for arm
  2015-11-27 10:23 ` Thomas Monjalon
@ 2015-11-27 10:50   ` Jerin Jacob
  0 siblings, 0 replies; 3+ messages in thread
From: Jerin Jacob @ 2015-11-27 10:50 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev

On Fri, Nov 27, 2015 at 11:23:01AM +0100, Thomas Monjalon wrote:
> Hi Jerin,
> 
> 2015-11-27 15:23, Jerin Jacob:
> > Commit 42ec27a0178a causes compiling error on arm, as RTE_SCHED_VECTOR
> > does support only SSE intrinsic, so disable it till we have neon support.
> > 
> > Fixes: 42ec27a0178a ("sched: enable SSE optimizations in config")
> > 
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
> >  config/defconfig_arm-armv7a-linuxapp-gcc     | 1 +
> >  config/defconfig_arm64-armv8a-linuxapp-gcc   | 1 +
> >  config/defconfig_arm64-thunderx-linuxapp-gcc | 1 +
> >  config/defconfig_arm64-xgene1-linuxapp-gcc   | 1 +
> 
> You would not need to update 4 files if the 3 last ones were including the
> first one.

armv7 and armv8 config parameters are quite different.I think we
can converge all the common configs of defconfig_arm64-*

> I think having an arm config base would also make clearer the differences
> between the arm platforms.

Yes, For armv8, I can update arm64-armv8a-linuxapp-gcc as a base config
and only absolute delta changes can be added to thunderx/xgene1 config.

I will send out the next revision with arm64-armv8a-linuxapp-gcc as
a base config.

Thanks
Jerin

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-11-27 10:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-27  9:53 [dpdk-dev] [PATCH] config: disable CONFIG_RTE_SCHED_VECTOR for arm Jerin Jacob
2015-11-27 10:23 ` Thomas Monjalon
2015-11-27 10:50   ` Jerin Jacob

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).