From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <3chas3@gmail.com>
Received: from mail-qg0-f50.google.com (mail-qg0-f50.google.com
 [209.85.192.50]) by dpdk.org (Postfix) with ESMTP id 9EA1137A6
 for <dev@dpdk.org>; Wed,  2 Dec 2015 00:58:16 +0100 (CET)
Received: by qgeb1 with SMTP id b1so20394478qge.1
 for <dev@dpdk.org>; Tue, 01 Dec 2015 15:58:16 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=message-id:subject:from:to:cc:date:in-reply-to:references
 :content-type:mime-version:content-transfer-encoding;
 bh=WZLhS6ynpqOCu7J8EjCORiq5U7DBF3dSb2Thq7KXDWo=;
 b=QcJSpi67hA2TRdOCO5bulvasRCiV1bA89GJ4/UhyaFpki/7YW0A/N+oW3q1PX1NaOk
 PXBeSMCujYDjPB32Jgm1haaKUwdujuBywhScCz/1pK67+fh9KGh541zxPD05jZjiksCo
 LPTCrukkqdf3UDJ4xHNbQMwMTxQmhXUMUG0WAfO8RsSY5/uCgYNDg/ahdy/E5TX58/mA
 GvSQj+p9GiiQCB2E7otbh03wpP4XP5LJeoLo+kTTjEX1KgIJ8yRO56FiM/D6wGQVzX50
 dTeamG/PxJ9ltdCCZkZleK2wHsIQ0lhrxw11WoLns62rOUXAXh+CWIeeAhQeFnTdjIRs
 PlUw==
X-Received: by 10.140.105.101 with SMTP id b92mr298841qgf.5.1449014296153;
 Tue, 01 Dec 2015 15:58:16 -0800 (PST)
Received: from foobar.home (pool-71-163-182-126.washdc.fios.verizon.net.
 [71.163.182.126])
 by smtp.googlemail.com with ESMTPSA id f7sm129140qkb.7.2015.12.01.15.58.15
 (version=TLSv1/SSLv3 cipher=OTHER);
 Tue, 01 Dec 2015 15:58:15 -0800 (PST)
Message-ID: <1449014294.2645.42.camel@gmail.com>
From: "Charles (Chas) Williams" <3chas3@gmail.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Date: Tue, 01 Dec 2015 18:58:14 -0500
In-Reply-To: <3362628.iLARgdqr6m@xps13>
References: <1446571576-28399-1-git-send-email-3chas3@gmail.com>
 <D283389F.103FAE%harish.patil@qlogic.com> <20151201143754.06675ca9@xeon-e3>
 <3362628.iLARgdqr6m@xps13>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] bnx2x: tx_start_bd->vlan_or_ethertype is le16
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Dec 2015 23:58:16 -0000

On Wed, 2015-12-02 at 00:34 +0100, Thomas Monjalon wrote:
> 2015-12-01 14:37, Stephen Hemminger:
> > Harish Patil <harish.patil@qlogic.com> wrote:
> > > >2015-11-03 12:26, Chas Williams:  
> > > >> --- a/drivers/net/bnx2x/bnx2x.c
> > > >> +++ b/drivers/net/bnx2x/bnx2x.c
> > > >> -                            tx_start_bd->vlan_or_ethertype = eh->ether_type;
> > > >> +                            tx_start_bd->vlan_or_ethertype
> > > >> +                                = rte_cpu_to_le_16(rte_be_to_cpu_16(eh->ether_type));
> > > 
> > > Minor question - any specific reason to use rte_be_to_cpu_16() on
> > > ether_type alone before converting from native order to le16?
> > 
> > ether_type is in network byte order (big endian)
> > and hardware wants little endian. On x86 the second step is a nop.
> 
> Doesn't it deserve a macro rte_ntole16()?
> It may be in lib/librte_eal/common/include/generic/rte_byteorder.h.

I looked I didn't see anything.  This value, according to the linux
driver, wants to be little endian regardless of the host endian.