DPDK patches and discussions
 help / color / mirror / Atom feed
From: Michael Qiu <michael.qiu@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v3] lib/librte_sched: Fix compile with gcc 4.3.4
Date: Wed,  2 Dec 2015 10:39:27 +0800	[thread overview]
Message-ID: <1449023967-26069-1-git-send-email-michael.qiu@intel.com> (raw)
In-Reply-To: <1448534997-24297-1-git-send-email-michael.qiu@intel.com>

gcc 4.3.4 does not include "immintrin.h", and will post below error:
    lib/librte_sched/rte_sched.c:56:23: error:
    immintrin.h: No such file or directory

This compiler issue is fixed with rte_vect.h

There is another issue, need SSE2 support

Fixes: 42ec27a0178a ("sched: enable SSE optimizations in config")

Signed-off-by: Michael Qiu <michael.qiu@intel.com>
---
v3 --> v2:
	reformat commit log
	move rte_vect.h inside RTE_SCHED_VECTOR

v2 --> v1:
	include header file rte_vect.h instead of gcc version check
	change __AVX__ to __SSE2__ since all vector function are SSE2 related

 lib/librte_sched/rte_sched.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c
index d47cfc2..21ebf25 100644
--- a/lib/librte_sched/rte_sched.c
+++ b/lib/librte_sched/rte_sched.c
@@ -53,7 +53,12 @@
 #endif
 
 #ifdef RTE_SCHED_VECTOR
-#include <immintrin.h>
+#include <rte_vect.h>
+
+#if defined(__SSE2__)
+#define SCHED_VECTOR_SSE2
+#endif
+
 #endif
 
 #define RTE_SCHED_TB_RATE_CONFIG_ERR          (1e-7)
@@ -1667,7 +1672,7 @@ grinder_schedule(struct rte_sched_port *port, uint32_t pos)
 	return 1;
 }
 
-#ifdef RTE_SCHED_VECTOR
+#ifdef SCHED_VECTOR_SSE2
 
 static inline int
 grinder_pipe_exists(struct rte_sched_port *port, uint32_t base_pipe)
-- 
1.9.3

  parent reply	other threads:[~2015-12-02  2:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-26 10:49 [dpdk-dev] [PATCH] " Michael Qiu
2015-11-26 21:28 ` Thomas Monjalon
2015-11-27  2:26   ` Qiu, Michael
2015-11-27  8:59     ` Thomas Monjalon
2015-11-27 11:53       ` Qiu, Michael
2015-11-27 12:34         ` Ananyev, Konstantin
2015-11-27 14:01           ` Qiu, Michael
2015-11-27 14:09             ` Ananyev, Konstantin
2015-11-27 15:22               ` Qiu, Michael
2015-11-27 16:21                 ` Ananyev, Konstantin
2015-12-02  2:09 ` [dpdk-dev] [PATCH v2] " Michael Qiu
2015-12-02  2:18   ` Thomas Monjalon
2015-12-02  2:29     ` Qiu, Michael
2015-12-02  2:39 ` Michael Qiu [this message]
2015-12-02 22:10   ` [dpdk-dev] [PATCH v3] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449023967-26069-1-git-send-email-michael.qiu@intel.com \
    --to=michael.qiu@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).