From: Stephen Hemminger <stephen@networkplumber.org>
To: huawei.xie@intel.com, yuanhan.liu@linux.intel.com,
bernard.iremonger@intel.com
Cc: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] virtio: fix link state regression
Date: Thu, 3 Dec 2015 18:08:24 -0800 [thread overview]
Message-ID: <1449194904-9626-1-git-send-email-stephen@networkplumber.org> (raw)
Support for link state interrupt was broken on virtio by
commit bda66c418c85 ("ethdev: add device fields from PCI layer")
This is caused because the actual value of drv_flags is not set
until after the resource_init has figured out whether it is using
UIO or direct I/O instructions.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
There maybe other drivers with the same problem. It would have
been better to move the structure elements (and break ABI) rather
than assume it safe to copy them. Better to fail compiling.
next reply other threads:[~2015-12-04 2:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 2:08 Stephen Hemminger [this message]
2015-12-04 3:29 ` Yuanhan Liu
2015-12-04 15:25 ` Iremonger, Bernard
2015-12-04 15:27 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449194904-9626-1-git-send-email-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).