From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com [209.85.220.41]) by dpdk.org (Postfix) with ESMTP id 1A8DB568A for ; Fri, 4 Dec 2015 03:08:18 +0100 (CET) Received: by pacdm15 with SMTP id dm15so78550756pac.3 for ; Thu, 03 Dec 2015 18:08:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=9qdayW8AypIeP6qJhEzQsk80p7RmBthvfM6USy+et+M=; b=BwgUQ6SPiqKXsVkPbalFby9fleISiLDreTbfPa+bsLIQC5vIedwOrXtykv82XqUG2g twai86WJ9hU1zLkc2lSr4f2aVYFuvuK57o1OuoJqoHB0q+iZ4HGzxoHbbR2mZWCz8MSs JoaxUIIkCnBEGKzzyeENjlSr5dTWK/Yj4zixSnwM0/KceSHPei/jdK8kMF5e13UORKh6 kGyi63QGnU8W7Keu7CnhRGjv+qM2K6844P7pBLYeVrzC6Yd6Gso1FP6O/v0aRv0gOrzu DY7Uac8T+OFRdaC1LOtClKk9i9DBlnopSUWxeDQ1ofW8jinIaQ5WCIOWrvDxfiYf8dop nvaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=9qdayW8AypIeP6qJhEzQsk80p7RmBthvfM6USy+et+M=; b=WxG8wDSqDVRznaB4idqNYlR8+wcWq9BKF+h0WRVQ6SQKZc/tWFHNPCGBCjau4DAAX5 OBaSJRpdXAdS/1Jyghb1f9ND7ewdR3cYcl5aarRe1Fy1GtkuDlS8AQqfbmNZefwFtDgN H7vebhgHG7FUscJ2baBucBwMJvjPUHAG0MxsTwlkM5oGWZiZCGdrMJN2TFoTPLqgZV+a 0IgWJexPZmyidiY/FQubOuiX9axUDFzNcTT9rIZWdQOyjiNYBG6coktxaQ+X27f3nnNR /wPwk7mJnThk6rDOPG4ojzYu6nU4o9K2azpoE7UmfNpzlVpDjolBONzEU38Rcd4uLP90 fQAg== X-Gm-Message-State: ALoCoQnPHOrVSgCTh44WiVvQFzxQtF7DCG8HqiZM6AZMBMw0zVTterB8cvfA1TQxifGUXoixX2ei X-Received: by 10.66.119.237 with SMTP id kx13mr17940670pab.158.1449194897233; Thu, 03 Dec 2015 18:08:17 -0800 (PST) Received: from xeon-e3.home.lan (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id 2sm13232979pfh.22.2015.12.03.18.08.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 03 Dec 2015 18:08:16 -0800 (PST) From: Stephen Hemminger To: huawei.xie@intel.com, yuanhan.liu@linux.intel.com, bernard.iremonger@intel.com Date: Thu, 3 Dec 2015 18:08:24 -0800 Message-Id: <1449194904-9626-1-git-send-email-stephen@networkplumber.org> X-Mailer: git-send-email 2.1.4 Cc: dev@dpdk.org Subject: [dpdk-dev] [PATCH] virtio: fix link state regression X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Dec 2015 02:08:18 -0000 Support for link state interrupt was broken on virtio by commit bda66c418c85 ("ethdev: add device fields from PCI layer") This is caused because the actual value of drv_flags is not set until after the resource_init has figured out whether it is using UIO or direct I/O instructions. Signed-off-by: Stephen Hemminger --- There maybe other drivers with the same problem. It would have been better to move the structure elements (and break ABI) rather than assume it safe to copy them. Better to fail compiling.