From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 5341E8E6E for ; Fri, 4 Dec 2015 15:38:35 +0100 (CET) Received: by wmec201 with SMTP id c201so67773302wme.1 for ; Fri, 04 Dec 2015 06:38:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=FpzWOlTWasH5LBMsuKyTVeAbEKojO+khEwEM1klnQJk=; b=AuQHm/kgt2t0gKwmFBJB+exkchOsbw/ZZ0omOGetMM3sGmEXnOfi9WKOajIwvgBPnL HcB3mvMrBKa3F2LYK9RLIOmugxfz/cd99FljjJ9wiju6+smUKen0XZ4Nv6ULKkykBsYP dcJzPuJBqRTwPzTeYgW6GccGClEMWitRk5NuM9pVdyCwxNi1Cj8MVxThfkmZd/nrmvu4 OjusWJ7VsLsHAI3Jyi/lnto8vm19Eh9GfKwYe7FXoQPvtpo9j21qQ1G4rnqm+ar7Dm2X wD/Lm5BGQaptci+Iu0KjagOgiOuea1XTtX7dqSEMBDmXjXQVHEy164wqW6BjERKI7BPC lOjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=FpzWOlTWasH5LBMsuKyTVeAbEKojO+khEwEM1klnQJk=; b=NoNacjmL9wUaEOavyISSeUwApQNO/NZRS5MKo+xMvaW1tphCojN4nHrMR+YN0so5CI e3JHClbGm51HFUdpOHYufYvYmGIzCXmZ5pCoTIxzop8lM1q4ihJ6YJZ2wSlXiDP7rH+0 MnRwtDEazSxcBZv71EjfkoSxUaQ8HnHB2tCuQnHEiSmIR+WhFgDU5f1shoJRWsqdOkMO Q4GNiivoEmbk2UQqHlflWIkgLDG3xSLldyY+M+dJqaMz2d0pM90c+mEH+naEyiz1Sajx iadUT8hHWyvZRG2K0NFcL2XSu7dxXgJqVH7479UYtrrweZ5RZcecccEo4MaJYGrcGGaJ YKCg== X-Gm-Message-State: ALoCoQn1dMV2S/ogjVuh7rQVAEX5Ixy5mPo2Ywi7fgV0LbdEROGa5p5QKBupASt5wEn5Y2xsjg6E X-Received: by 10.28.6.130 with SMTP id 124mr5715763wmg.7.1449239915131; Fri, 04 Dec 2015 06:38:35 -0800 (PST) Received: from alcyon.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id a186sm3780433wmh.4.2015.12.04.06.38.33 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 04 Dec 2015 06:38:34 -0800 (PST) From: David Marchand To: dev@dpdk.org Date: Fri, 4 Dec 2015 15:38:13 +0100 Message-Id: <1449239893-4012-1-git-send-email-david.marchand@6wind.com> X-Mailer: git-send-email 1.7.10.4 Subject: [dpdk-dev] [PATCH] mk: fix objects/library order when linking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Dec 2015 14:38:35 -0000 It is safer to specify libraries we depend on after the objects we are linking into a shared library, especially when the linker is invoked with options like --as-needed. Fixes: bef06a8a0655 ("mk: set library dependencies in shared object file") Signed-off-by: David Marchand --- mk/rte.lib.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk index 06a1519..1f1b6e1 100644 --- a/mk/rte.lib.mk +++ b/mk/rte.lib.mk @@ -82,7 +82,7 @@ O_TO_A_DO = @set -e; \ $(O_TO_A) && \ echo $(O_TO_A_CMD) > $(call exe2cmd,$(@)) -O_TO_S = $(LD) $(_CPU_LDFLAGS) $(EXTRA_LDFLAGS) $(LDLIBS) -shared $(OBJS-y) \ +O_TO_S = $(LD) $(_CPU_LDFLAGS) $(EXTRA_LDFLAGS) -shared $(OBJS-y) $(LDLIBS) \ -Wl,-soname,$(LIB) -o $(LIB) O_TO_S_STR = $(subst ','\'',$(O_TO_S)) #'# fix syntax highlight O_TO_S_DISP = $(if $(V),"$(O_TO_S_STR)"," LD $(@)") -- 1.7.10.4