From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wes1-so1.wedos.net (wes1-so1.wedos.net [46.28.106.15]) by dpdk.org (Postfix) with ESMTP id 357CB5952 for ; Wed, 9 Dec 2015 16:17:09 +0100 (CET) Received: from pcviktorin.fit.vutbr.cz (pcviktorin.fit.vutbr.cz [147.229.13.147]) by wes1-so1.wedos.net (Postfix) with ESMTPSA id 3pG26X5s15z3BQ; Wed, 9 Dec 2015 16:17:08 +0100 (CET) From: Jan Viktorin To: dev@dpdk.org Date: Wed, 9 Dec 2015 16:16:17 +0100 Message-Id: <1449674177-10624-1-git-send-email-viktorin@rehivetech.com> X-Mailer: git-send-email 2.6.3 In-Reply-To: <1449602993-6047-1-git-send-email-viktorin@rehivetech.com> References: <1449602993-6047-1-git-send-email-viktorin@rehivetech.com> Subject: [dpdk-dev] [PATCH 1/1] arm: set CONFIG_RTE_ARCH_STRICT_ALIGN=y for armv7 target X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Dec 2015 15:17:09 -0000 This patch reduces number of warnings from 53 to 40. It removes the usual false positives utilizing unaligned_uint*_t data types. Signed-off-by: Jan Viktorin --- As far as I know, only a 64-bit unaligned access can be a problem for ARMv7. I found only one such occurence: 118 struct rte_mbuf * 119 rte_ipv4_frag_reassemble_packet(struct rte_ip_frag_tbl *tbl, 120 struct rte_ip_frag_death_row *dr, struct rte_mbuf *mb, uint64_t tms, 121 struct ipv4_hdr *ip_hdr) ... 133 psd = (unaligned_uint64_t *)&ip_hdr->src_addr; 134 /* use first 8 bytes only */ 135 key.src_dst[0] = psd[0]; 136 key.id = ip_hdr->packet_id; 137 key.key_len = IPV4_KEYLEN Is this a real issue? --- config/defconfig_arm-armv7a-linuxapp-gcc | 1 + 1 file changed, 1 insertion(+) diff --git a/config/defconfig_arm-armv7a-linuxapp-gcc b/config/defconfig_arm-armv7a-linuxapp-gcc index cbebd64..2482d91 100644 --- a/config/defconfig_arm-armv7a-linuxapp-gcc +++ b/config/defconfig_arm-armv7a-linuxapp-gcc @@ -39,6 +39,7 @@ CONFIG_RTE_ARCH_ARM_TUNE="cortex-a9" CONFIG_RTE_ARCH_ARM_NEON=y CONFIG_RTE_FORCE_INTRINSICS=y +CONFIG_RTE_ARCH_STRICT_ALIGN=y CONFIG_RTE_TOOLCHAIN="gcc" CONFIG_RTE_TOOLCHAIN_GCC=y -- 2.6.3