From: Fan Zhang <roy.fan.zhang@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] example/ip_pipeline: fix value overwrite
Date: Fri, 11 Dec 2015 11:29:11 +0000 [thread overview]
Message-ID: <1449833351-10011-6-git-send-email-roy.fan.zhang@intel.com> (raw)
In-Reply-To: <1449833351-10011-1-git-send-email-roy.fan.zhang@intel.com>
Coverity issue: 107136
Fixes: 7f64b9c004aa ("examples/ip_pipeline: rework config file syntax")
Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
examples/ip_pipeline/config_parse.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/examples/ip_pipeline/config_parse.c b/examples/ip_pipeline/config_parse.c
index 67e58c9..4e194d6 100644
--- a/examples/ip_pipeline/config_parse.c
+++ b/examples/ip_pipeline/config_parse.c
@@ -1631,8 +1631,8 @@ parse_tm(struct app_params *app,
param->file_name = strdup(ent->value);
if (param->file_name == NULL)
ret = -EINVAL;
-
- ret = 0;
+ else
+ ret = 0;
} else if (strcmp(ent->name, "burst_read") == 0)
ret = parser_read_uint32(¶m->burst_read,
ent->value);
--
2.5.0
next prev parent reply other threads:[~2015-12-11 11:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 11:29 [dpdk-dev] [PATCH] example/ip_pipeline: fix buffer size warning Fan Zhang
2015-12-11 11:29 ` [dpdk-dev] [PATCH] example/ip_pipeline: fix copy into fixed size buffer defect Fan Zhang
2015-12-11 15:37 ` Mcnamara, John
2015-12-11 16:16 ` Richardson, Bruce
2015-12-11 11:29 ` [dpdk-dev] [PATCH] example/ip_pipeline: fix copy-paste error Fan Zhang
2015-12-11 15:20 ` Mcnamara, John
2015-12-11 11:29 ` [dpdk-dev] [PATCH] example/ip_pipeline: fix logically deadnode defect Fan Zhang
2015-12-11 15:22 ` Mcnamara, John
2015-12-11 11:29 ` [dpdk-dev] [PATCH] example/ip_pipeline: fix overrunning byffer defect Fan Zhang
2015-12-11 15:25 ` Mcnamara, John
2015-12-11 11:29 ` Fan Zhang [this message]
2015-12-11 15:44 ` [dpdk-dev] [PATCH] example/ip_pipeline: fix value overwrite Mcnamara, John
2015-12-11 14:59 ` [dpdk-dev] [PATCH] example/ip_pipeline: fix buffer size warning Mcnamara, John
2015-12-13 1:34 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449833351-10011-6-git-send-email-roy.fan.zhang@intel.com \
--to=roy.fan.zhang@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).