DPDK patches and discussions
 help / color / mirror / Atom feed
From: Aaron Conole <aconole@redhat.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 2.3] tools/dpdk_nic_bind.py: Verbosely warn the user on bind
Date: Fri, 11 Dec 2015 11:20:23 -0500	[thread overview]
Message-ID: <1449850823-29017-1-git-send-email-aconole@redhat.com> (raw)

DPDK ports are only detected during the EAL initialization. After that, any
new DPDK ports which are bound will not be visible to the application.

The dpdk_nic_bind.py can be a bit more helpful to let users know that DPDK
enabled applications will not find rebound ports until after they have been
restarted.

Signed-off-by: Aaron Conole <aconole@redhat.com>
---
 tools/dpdk_nic_bind.py | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tools/dpdk_nic_bind.py b/tools/dpdk_nic_bind.py
index f02454e..ca39389 100755
--- a/tools/dpdk_nic_bind.py
+++ b/tools/dpdk_nic_bind.py
@@ -344,8 +344,10 @@ def bind_one(dev_id, driver, force):
             dev["Driver_str"] = "" # clear driver string
 
     # if we are binding to one of DPDK drivers, add PCI id's to that driver
+    bDpdkDriver = False
     if driver in dpdk_drivers:
         filename = "/sys/bus/pci/drivers/%s/new_id" % driver
+        bDpdkDriver = True
         try:
             f = open(filename, "w")
         except:
@@ -371,12 +373,18 @@ def bind_one(dev_id, driver, force):
     try:
         f.write(dev_id)
         f.close()
+        if bDpdkDriver:
+            print "Device rebound to dpdk driver."
+            print "Remember to restart any application that will use this port."
     except:
         # for some reason, closing dev_id after adding a new PCI ID to new_id
         # results in IOError. however, if the device was successfully bound,
         # we don't care for any errors and can safely ignore IOError
         tmp = get_pci_device_details(dev_id)
         if "Driver_str" in tmp and tmp["Driver_str"] == driver:
+            if bDpdkDriver:
+                print "Device rebound to dpdk driver."
+                print "Remember to restart any application that will use this port."
             return
         print "Error: bind failed for %s - Cannot bind to driver %s" % (dev_id, driver)
         if saved_driver is not None: # restore any previous driver
-- 
2.6.1.133.gf5b6079

             reply	other threads:[~2015-12-11 16:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-11 16:20 Aaron Conole [this message]
2016-01-26 20:14 ` Thomas Monjalon
2016-01-26 20:21   ` David Marchand
2016-03-01  8:38     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449850823-29017-1-git-send-email-aconole@redhat.com \
    --to=aconole@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).