DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: helin.zhang@intel.com, konstantin.ananyev@intel.com
Cc: dev@dpdk.org, "Charles \(Chas\) Williams" <ciwillia@brocade.com>
Subject: [dpdk-dev] [PATCH] nohz: disable traceback on NO_HZ warning
Date: Mon, 14 Dec 2015 10:26:07 -0800	[thread overview]
Message-ID: <1450117567-12173-1-git-send-email-stephen@networkplumber.org> (raw)

From: "Charles (Chas) Williams" <ciwillia@brocade.com>

A NO_HZ_FULL kernel needs to have a stable clock source like a non-stop
(or invariant) TSC.  Unfortunately, this CPU feature/flag isn't advertised
by most hypervisors because they want the ability to migrate or save
virtual machines which would affect the TSC.

This means that a kernel with NO_HZ_FULL configured would often generate
a kernel traceback on boot which causes users to generate false
alarms. NO_HZ_FULL is an optimization not a hard requirement.
Keep the message, just lose the traceback.

Signed-off-by: Charles (Chas) Williams <ciwillia@brocade.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 kernel/time/tick-sched.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index 7c7ec45..2e1c90c 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -188,8 +188,8 @@ static bool can_stop_full_tick(void)
 		 * Don't allow the user to think they can get
 		 * full NO_HZ with this machine.
 		 */
-		WARN_ONCE(tick_nohz_full_running,
-			  "NO_HZ FULL will not work with unstable sched clock");
+		if (tick_nohz_full_running)
+			pr_notice_once("NO_HZ FULL will not work with unstable sched clock\n");
 		return false;
 	}
 #endif
-- 
2.1.4

             reply	other threads:[~2015-12-14 18:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-14 18:26 Stephen Hemminger [this message]
2015-12-14 19:13 ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1450117567-12173-1-git-send-email-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=ciwillia@brocade.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    --cc=konstantin.ananyev@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).