From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 1AE8695A0 for ; Wed, 6 Jan 2016 15:33:32 +0100 (CET) Received: by mail-wm0-f51.google.com with SMTP id u188so62333299wmu.1 for ; Wed, 06 Jan 2016 06:33:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=nu2GuD4dxxC0gyjrxIN6sRLUCuKnWY3POmYBizY+lc8=; b=uAzTfrnraWi4rFD305RIYRpmytgun6zl5d+negFkubQO5rSKfiMcSNo462sF6z1NUH iT3AKmDlDvXjbia0X7kFrh9a9ZGbXAE2/i6LlodYi7Kr8rMpNGyNe+w5NjFT6gpISLdd K90JTp2kUjgHL6rmQQwHY2lqSkBVvmZpffIOV5l1unKJgtvJqABW8xs5YLuIMDzUsFDN /G9K9nAhg5OZ88XSxc5i/NnSVDBzbzrBfi4iGeSM5+ANzp2Nr8SYRkixshEh1iKv3OQD X5iFFG1do1mW/VKwohSMAEybv0VP2kxehh6qpy0b8AONxHjj04U7qS3txiFPT2is8Uyw a47g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=nu2GuD4dxxC0gyjrxIN6sRLUCuKnWY3POmYBizY+lc8=; b=M+r4ttg6kJJoP4tCEk0CuVvZrR/XdscoqSV4KxKgfjQc54raCeewKp/bLRfs6t4Uyp oCcWfqwznWOrDw7tjpx6iOPGvp8YpfFMLY8GzbF/t4U8AcjPH7vJecJM7ZxS9u0k0v6R 9CYLz1Zc/80FHUmywu7HseeIwWQroGnPQEMqX499IJnJjagt9c7/vioL7uxhQ28RSWeH Xfx3PNtkeFw3uIJ6xUKwxSi3XN6ZGm3utdTrM+nCpCgvdYQcdHvvzYhqHOA4tHH/78IV rN1qBbNQMrf7EDc6EtU4mEIiYcX9e+1OEqXmdAil1sOD1GpNVOofhWv8y0OL6esjw1d0 H3cQ== X-Gm-Message-State: ALoCoQn/Ak7VbDx8XAks0vVZK1ZfI3UuCDdWidqYz2tX6Y/oDS0oMXWnKJqefwZGZTxmHuNh9KucagCI/l92phyjXrfLsMedyA== X-Received: by 10.28.173.208 with SMTP id w199mr9901643wme.45.1452090811961; Wed, 06 Jan 2016 06:33:31 -0800 (PST) Received: from ping.vm.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id ft4sm96246519wjb.37.2016.01.06.06.33.30 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 06 Jan 2016 06:33:31 -0800 (PST) From: Nelio Laranjeiro To: dev@dpdk.org Date: Wed, 6 Jan 2016 15:32:53 +0100 Message-Id: <1452090774-10650-3-git-send-email-nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1452090774-10650-1-git-send-email-nelio.laranjeiro@6wind.com> References: <1452090774-10650-1-git-send-email-nelio.laranjeiro@6wind.com> Subject: [dpdk-dev] [PATCH 2/3] cmdline: increase command line buffer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jan 2016 14:33:32 -0000 For RETA query/update with a table of 512 entries, buffers are too small to handle the request. Signed-off-by: Nelio Laranjeiro --- doc/guides/rel_notes/deprecation.rst | 5 ----- lib/librte_cmdline/cmdline_parse.h | 2 +- lib/librte_cmdline/cmdline_parse_string.h | 2 +- lib/librte_cmdline/cmdline_rdline.h | 2 +- 4 files changed, 3 insertions(+), 8 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index e8a3ed6..9930b5a 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -39,8 +39,3 @@ Deprecation Notices and table action handlers will be updated: the pipeline parameter will be added, the packets mask parameter will be either removed (for input port action handler) or made input-only. - -* ABI changes are planned in cmdline buffer size to allow the use of long - commands (such as RETA update in testpmd). This should impact - CMDLINE_PARSE_RESULT_BUFSIZE, STR_TOKEN_SIZE and RDLINE_BUF_SIZE. - It should be integrated in release 2.3. diff --git a/lib/librte_cmdline/cmdline_parse.h b/lib/librte_cmdline/cmdline_parse.h index 4b25c45..89b28b1 100644 --- a/lib/librte_cmdline/cmdline_parse.h +++ b/lib/librte_cmdline/cmdline_parse.h @@ -81,7 +81,7 @@ extern "C" { #define CMDLINE_PARSE_COMPLETED_BUFFER 2 /* maximum buffer size for parsed result */ -#define CMDLINE_PARSE_RESULT_BUFSIZE 8192 +#define CMDLINE_PARSE_RESULT_BUFSIZE 65536 /** * Stores a pointer to the ops struct, and the offset: the place to diff --git a/lib/librte_cmdline/cmdline_parse_string.h b/lib/librte_cmdline/cmdline_parse_string.h index c205622..61e0627 100644 --- a/lib/librte_cmdline/cmdline_parse_string.h +++ b/lib/librte_cmdline/cmdline_parse_string.h @@ -66,7 +66,7 @@ extern "C" { #endif /* size of a parsed string */ -#define STR_TOKEN_SIZE 128 +#define STR_TOKEN_SIZE 8192 typedef char cmdline_fixed_string_t[STR_TOKEN_SIZE]; diff --git a/lib/librte_cmdline/cmdline_rdline.h b/lib/librte_cmdline/cmdline_rdline.h index b9aad9b..07f8faa 100644 --- a/lib/librte_cmdline/cmdline_rdline.h +++ b/lib/librte_cmdline/cmdline_rdline.h @@ -93,7 +93,7 @@ extern "C" { #endif /* configuration */ -#define RDLINE_BUF_SIZE 256 +#define RDLINE_BUF_SIZE 16384 #define RDLINE_PROMPT_SIZE 32 #define RDLINE_VT100_BUF_SIZE 8 #define RDLINE_HISTORY_BUF_SIZE BUFSIZ -- 2.1.4