From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <shurd@broadcom.com>
Received: from mail-gw2-out.broadcom.com (mail-gw2-out.broadcom.com
 [216.31.210.63]) by dpdk.org (Postfix) with ESMTP id 7BD928E69
 for <dev@dpdk.org>; Wed, 13 Jan 2016 23:23:50 +0100 (CET)
X-IronPort-AV: E=Sophos;i="5.22,291,1449561600"; d="scan'208";a="85521151"
Received: from irvexchcas08.broadcom.com (HELO
 IRVEXCHCAS08.corp.ad.broadcom.com) ([10.9.208.57])
 by mail-gw2-out.broadcom.com with ESMTP; 13 Jan 2016 15:04:30 -0800
Received: from IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) by
 IRVEXCHCAS08.corp.ad.broadcom.com (10.9.208.57) with Microsoft SMTP Server
 (TLS) id 14.3.235.1; Wed, 13 Jan 2016 14:23:49 -0800
Received: from mail-irva-13.broadcom.com (10.10.10.20) by
 IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) with Microsoft SMTP Server id
 14.3.235.1; Wed, 13 Jan 2016 14:23:49 -0800
Received: from DPDK-C1.broadcom.com (lab-irv-114-50 [10.13.114.50])	by
 mail-irva-13.broadcom.com (Postfix) with ESMTP id 455E240FE5;	Wed, 13 Jan
 2016 14:20:04 -0800 (PST)
From: Stephen Hurd <shurd@broadcom.com>
To: <dev@dpdk.org>
Date: Wed, 13 Jan 2016 14:23:36 -0800
Message-ID: <1452723816-73141-1-git-send-email-shurd@broadcom.com>
X-Mailer: git-send-email 1.9.1
In-Reply-To: <24888901-A45C-4E23-871E-3485AF2423D2@intel.com>
References: <24888901-A45C-4E23-871E-3485AF2423D2@intel.com>
MIME-Version: 1.0
Content-Type: text/plain
Subject: [dpdk-dev] [PATCH v2] app/testpmd Fix max_socket detection
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Jan 2016 22:23:50 -0000

Previously, max_socket was set to the highest numbered socket with
an enabled lcore.  The intent is to set it to the highest socket
regardless of it being enabled.

Change-Id: I6306af0f90aa3c1fc5ffed75d1eed8297d29e132
Signed-off-by: Stephen Hurd <shurd@broadcom.com>

v2: Forgot to commit before sending email... sorry for the nouse.
---
 app/test-pmd/testpmd.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 6129c26..a4088f9 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -359,17 +359,17 @@ set_default_fwd_lcores_config(void)
 
 	nb_lc = 0;
 	for (i = 0; i < RTE_MAX_LCORE; i++) {
-		if (! rte_lcore_is_enabled(i))
-			continue;
-		if (i == rte_get_master_lcore())
-			continue;
-		fwd_lcores_cpuids[nb_lc++] = i;
 		sock_num = rte_lcore_to_socket_id(i) + 1;
 		if (sock_num > max_socket) {
 			if (sock_num > RTE_MAX_NUMA_NODES)
 				rte_exit(EXIT_FAILURE, "Total sockets greater than %u\n", RTE_MAX_NUMA_NODES);
 			max_socket = sock_num;
 		}
+		if (! rte_lcore_is_enabled(i))
+			continue;
+		if (i == rte_get_master_lcore())
+			continue;
+		fwd_lcores_cpuids[nb_lc++] = i;
 	}
 	nb_lcores = (lcoreid_t) nb_lc;
 	nb_cfg_lcores = nb_lcores;
-- 
1.9.1