From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f171.google.com (mail-we0-f171.google.com [74.125.82.171]) by dpdk.org (Postfix) with ESMTP id 21C8C5930 for ; Thu, 24 Jul 2014 10:06:21 +0200 (CEST) Received: by mail-we0-f171.google.com with SMTP id p10so2384825wes.2 for ; Thu, 24 Jul 2014 01:07:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=/lRIjLe7dw2NlF4Ylguga2GMEI8pXdc90HRa16ZYIV0=; b=Dl5Jqzbq4j8MNZqwS0uQ5vjgdjmJRL8TLgo/l+hMBVY64exBAh+e/qfa7xMhL5rmXM s7MkwLJ1qPxd78RKVxlkEdaTki3P6hsrvGg459diFj1ZAHcWLeatqIvg/Syy0xFBlXVW uzXtsXlScJVVXMg6LF8Mizu1yFbmqM+29f1rQ1f2gvNXQD5Il8dcFTOorbF1hADBHaO5 bGRvSwgvH/iy8Of07PQ41/2DnYcGOS6dtGKKwhcxhSeB46DpWDdvk3wAHGZpiFK4uyPo w9kmikpu3cdzfxJMyEuHutrUPOwTkEabbblxLlqq9EQYkPyUpXMYkNvsseX0WCwcBNNK ssRA== X-Gm-Message-State: ALoCoQnOlzjesE46/pwlehJD/6UdarLDpCPiwyU6YlVPL35rac/4dGuDlCFO0IAvFAEdN2TlAZRE X-Received: by 10.194.6.10 with SMTP id w10mr9501185wjw.51.1406189268290; Thu, 24 Jul 2014 01:07:48 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id es9sm9588845wjd.1.2014.07.24.01.07.46 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Jul 2014 01:07:47 -0700 (PDT) From: Thomas Monjalon To: Matthew Hall , Helin Zhang Date: Thu, 24 Jul 2014 10:07:37 +0200 Message-ID: <1454201.eyrodsIZYi@xps13> Organization: 6WIND User-Agent: KMail/4.13.2 (Linux/3.15.5-2-ARCH; KDE/4.13.2; x86_64; ; ) In-Reply-To: <20140724080113.GB21277@mhcomputing.net> References: <1406184149-11531-1-git-send-email-helin.zhang@intel.com> <9589603.4uh6CsY5aa@xps13> <20140724080113.GB21277@mhcomputing.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 3/5] i40e: support selecting hash functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2014 08:06:21 -0000 2014-07-24 01:01, Matthew Hall: > On Thu, Jul 24, 2014 at 09:59:23AM +0200, Thomas Monjalon wrote: > > Is it really a good idea to configure this kind of thing at build time? > > Maybe yes, I'm not sure. > > Whether it's safe to set at runtime probably depends what happens to the card > if it gets changed. Do you have to reset the card or the port? Or is it OK if > it's more dynamic? No, we can change configuration with rte_eth_dev_configure() before initializing port. So it is truly configurable. Requiring recompilation means it's not really configurable between 2 runs. And it breaks binary packaging for Linux distributions. Many things in DPDK are configured at build time. But we should wonder if it's really a good design. -- Thomas