DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 1/3] eal/x86: fix build with clang for old AVX
Date: Wed,  3 Feb 2016 19:56:37 +0100	[thread overview]
Message-ID: <1454525799-25552-2-git-send-email-thomas.monjalon@6wind.com> (raw)
In-Reply-To: <1454525799-25552-1-git-send-email-thomas.monjalon@6wind.com>

When configuring RTE_MACHINE to "default", rte_memcpy implementation
is the default one (old AVX).
In this code, clang raises a warning thanks to -Wsometimes-uninitialized:

rte_memcpy.h:838:6: error:
variable 'srcofs' is used uninitialized whenever 'if' condition is false
        if (dstofss > 0) {
            ^~~~~~~~~~~
rte_memcpy.h:849:6: note: uninitialized use occurs here
        if (srcofs == 0) {
            ^~~~~~

It is fixed by initializing srcofs to 0.

Fixes: 1ae817f9f887 ("eal/x86: tune memcpy for platforms without AVX512")

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 lib/librte_eal/common/include/arch/x86/rte_memcpy.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h
index 8e2c53c..5badfbc 100644
--- a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h
+++ b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h
@@ -739,7 +739,7 @@ rte_memcpy(void *dst, const void *src, size_t n)
 	uintptr_t srcu = (uintptr_t)src;
 	void *ret = dst;
 	size_t dstofss;
-	size_t srcofs;
+	size_t srcofs = 0;
 
 	/**
 	 * Copy less than 16 bytes
-- 
2.7.0

  reply	other threads:[~2016-02-03 18:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-03 18:56 [dpdk-dev] [PATCH 0/3] fix build for default machine Thomas Monjalon
2016-02-03 18:56 ` Thomas Monjalon [this message]
2016-02-04  3:35   ` [dpdk-dev] [PATCH 1/3] eal/x86: fix build with clang for old AVX Wang, Zhihong
2016-02-04  8:47     ` Thomas Monjalon
2016-02-04  9:21       ` Thomas Monjalon
2016-02-03 18:56 ` [dpdk-dev] [PATCH 2/3] examples/l3fwd: fix build without SSE4.1 Thomas Monjalon
2016-02-08 14:09   ` De Lara Guarch, Pablo
2016-02-03 18:56 ` [dpdk-dev] [PATCH 3/3] examples/ip_pipeline: fix build for x86_64 without SSE4.2 Thomas Monjalon
2016-02-16  6:53 ` [dpdk-dev] [PATCH 0/3] fix build for default machine Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454525799-25552-2-git-send-email-thomas.monjalon@6wind.com \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).