[dpdk-dev] [PATCH 1/2] fm10k: Add Atwood Channel Support

[dpdk-dev] [PATCH 1/2] fm10k: Add Atwood Channel Support

[Michael Qiu]

Atwood Channel is intel 25G NIC, and this patch add the support
in DPDK.

Signed-off-by: Michael Qiu<michael.qiu@intel.com>
---
 drivers/net/fm10k/base/fm10k_osdep.h            | 4 ++++
 lib/librte_eal/common/include/rte_pci_dev_ids.h | 2 ++
 2 files changed, 6 insertions(+)

diff --git a/drivers/net/fm10k/base/fm10k_osdep.h b/drivers/net/fm10k/base/fm10k_osdep.h
index 6852ef0..9cb46ff 100644
--- a/drivers/net/fm10k/base/fm10k_osdep.h
+++ b/drivers/net/fm10k/base/fm10k_osdep.h
@@ -48,6 +48,10 @@ POSSIBILITY OF SUCH DAMAGE.
 #define BOULDER_RAPIDS_HW
 #endif
 
+#ifndef ATWOOD_CHANNEL_HW
+#define ATWOOD_CHANNEL_HW
+#endif
+
 #define STATIC                  static
 #define DEBUGFUNC(F)            DEBUGOUT(F "\n");
 #define DEBUGOUT(S, args...)    PMD_DRV_LOG_RAW(DEBUG, S, ##args)
diff --git a/lib/librte_eal/common/include/rte_pci_dev_ids.h b/lib/librte_eal/common/include/rte_pci_dev_ids.h
index e31b934..cb0d177 100644
--- a/lib/librte_eal/common/include/rte_pci_dev_ids.h
+++ b/lib/librte_eal/common/include/rte_pci_dev_ids.h
@@ -530,9 +530,11 @@ RTE_PCI_DEV_ID_DECL_I40E(PCI_VENDOR_ID_INTEL, I40E_DEV_ID_10G_BASE_T_X722)
 
 #define FM10K_DEV_ID_PF                   0x15A4
 #define FM10K_DEV_ID_SDI_FM10420_QDA2     0x15D0
+#define FM10K_DEV_ID_SDI_FM10420_DA2      0x15D5
 
 RTE_PCI_DEV_ID_DECL_FM10K(PCI_VENDOR_ID_INTEL, FM10K_DEV_ID_PF)
 RTE_PCI_DEV_ID_DECL_FM10K(PCI_VENDOR_ID_INTEL, FM10K_DEV_ID_SDI_FM10420_QDA2)
+RTE_PCI_DEV_ID_DECL_FM10K(PCI_VENDOR_ID_INTEL, FM10K_DEV_ID_SDI_FM10420_DA2)
 
 /****************** Virtual IGB devices from e1000_hw.h ******************/
 
-- 
1.9.3

[dpdk-dev] [PATCH 2/2] fm10k: update doc for Atwood Channel

[Michael Qiu]

Atwood Channel is 20GbE NIC and belongs to Intel FM10K family,
update the doc for it.

Signed-off-by: Michael Qiu <michael.qiu@intel.com>
---
 doc/guides/rel_notes/release_2_3.rst | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/doc/guides/rel_notes/release_2_3.rst b/doc/guides/rel_notes/release_2_3.rst
index 99de186..7dd9c0f 100644
--- a/doc/guides/rel_notes/release_2_3.rst
+++ b/doc/guides/rel_notes/release_2_3.rst
@@ -3,7 +3,9 @@ DPDK Release 2.3
 
 New Features
 ------------
+* **New NIC Atwood Channel support.**
 
+  Added support for the Atwood Channel variant of Intel's fm10k NIC family.
 
 Resolved Issues
 ---------------
-- 
1.9.3

Re: [dpdk-dev] [PATCH 2/2] fm10k: update doc for Atwood Channel

[Mcnamara, John]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michael Qiu
> Sent: Monday, January 11, 2016 7:28 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH 2/2] fm10k: update doc for Atwood Channel
> 
> Atwood Channel is 20GbE NIC and belongs to Intel FM10K family, update the
> doc for it.
> 
> Signed-off-by: Michael Qiu <michael.qiu@intel.com>

Acked-by: John McNamara <john.mcnamara@intel.com>

Re: [dpdk-dev] [PATCH 2/2] fm10k: update doc for Atwood Channel

[Chen, Jing D]

Hi,

Best Regards,
Mark


> -----Original Message-----
> From: Qiu, Michael
> Sent: Monday, January 11, 2016 3:28 PM
> To: dev@dpdk.org
> Cc: Chen, Jing D; Qiu, Michael
> Subject: [PATCH 2/2] fm10k: update doc for Atwood Channel
> 
> Atwood Channel is 20GbE NIC and belongs to Intel FM10K family,
> update the doc for it.

There is a typo above. It's 25G, not 20.

> 
> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> ---
>  doc/guides/rel_notes/release_2_3.rst | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/release_2_3.rst
> b/doc/guides/rel_notes/release_2_3.rst
> index 99de186..7dd9c0f 100644
> --- a/doc/guides/rel_notes/release_2_3.rst
> +++ b/doc/guides/rel_notes/release_2_3.rst
> @@ -3,7 +3,9 @@ DPDK Release 2.3
> 
>  New Features
>  ------------
> +* **New NIC Atwood Channel support.**
> 
> +  Added support for the Atwood Channel variant of Intel's fm10k NIC family.
> 
>  Resolved Issues
>  ---------------
> --
> 1.9.3

Re: [dpdk-dev] [PATCH 1/2] fm10k: Add Atwood Channel Support

[Mcnamara, John]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michael Qiu
> Sent: Monday, January 11, 2016 7:28 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH 1/2] fm10k: Add Atwood Channel Support
> 
> Atwood Channel is intel 25G NIC, and this patch add the support in DPDK.
> 
> Signed-off-by: Michael Qiu<michael.qiu@intel.com>

Acked-by: John McNamara <john.mcnamara@intel.com>

[dpdk-dev] [PATCH 1/2 v2] fm10k: Add Atwood Channel Support

[Michael Qiu]

Atwood Channel is intel 25G NIC, and this patch add the support
in DPDK.

Signed-off-by: Michael Qiu<michael.qiu@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
---
 drivers/net/fm10k/base/fm10k_osdep.h            | 4 ++++
 lib/librte_eal/common/include/rte_pci_dev_ids.h | 2 ++
 2 files changed, 6 insertions(+)

diff --git a/drivers/net/fm10k/base/fm10k_osdep.h b/drivers/net/fm10k/base/fm10k_osdep.h
index 6852ef0..9cb46ff 100644
--- a/drivers/net/fm10k/base/fm10k_osdep.h
+++ b/drivers/net/fm10k/base/fm10k_osdep.h
@@ -48,6 +48,10 @@ POSSIBILITY OF SUCH DAMAGE.
 #define BOULDER_RAPIDS_HW
 #endif
 
+#ifndef ATWOOD_CHANNEL_HW
+#define ATWOOD_CHANNEL_HW
+#endif
+
 #define STATIC                  static
 #define DEBUGFUNC(F)            DEBUGOUT(F "\n");
 #define DEBUGOUT(S, args...)    PMD_DRV_LOG_RAW(DEBUG, S, ##args)
diff --git a/lib/librte_eal/common/include/rte_pci_dev_ids.h b/lib/librte_eal/common/include/rte_pci_dev_ids.h
index e31b934..cb0d177 100644
--- a/lib/librte_eal/common/include/rte_pci_dev_ids.h
+++ b/lib/librte_eal/common/include/rte_pci_dev_ids.h
@@ -530,9 +530,11 @@ RTE_PCI_DEV_ID_DECL_I40E(PCI_VENDOR_ID_INTEL, I40E_DEV_ID_10G_BASE_T_X722)
 
 #define FM10K_DEV_ID_PF                   0x15A4
 #define FM10K_DEV_ID_SDI_FM10420_QDA2     0x15D0
+#define FM10K_DEV_ID_SDI_FM10420_DA2      0x15D5
 
 RTE_PCI_DEV_ID_DECL_FM10K(PCI_VENDOR_ID_INTEL, FM10K_DEV_ID_PF)
 RTE_PCI_DEV_ID_DECL_FM10K(PCI_VENDOR_ID_INTEL, FM10K_DEV_ID_SDI_FM10420_QDA2)
+RTE_PCI_DEV_ID_DECL_FM10K(PCI_VENDOR_ID_INTEL, FM10K_DEV_ID_SDI_FM10420_DA2)
 
 /****************** Virtual IGB devices from e1000_hw.h ******************/
 
-- 
1.9.3

[dpdk-dev] [PATCH 2/2 v2] fm10k: update doc for Atwood Channel

[Michael Qiu]

Atwood Channel is 25GbE NIC and belongs to Intel FM10K family,
update the doc for it.

Signed-off-by: Michael Qiu <michael.qiu@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
---
Change log:
   1. modify 20GbE to 25GbE 

 doc/guides/rel_notes/release_2_3.rst | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/doc/guides/rel_notes/release_2_3.rst b/doc/guides/rel_notes/release_2_3.rst
index 99de186..7dd9c0f 100644
--- a/doc/guides/rel_notes/release_2_3.rst
+++ b/doc/guides/rel_notes/release_2_3.rst
@@ -3,7 +3,9 @@ DPDK Release 2.3
 
 New Features
 ------------
+* **New NIC Atwood Channel support.**
 
+  Added support for the Atwood Channel variant of Intel's fm10k NIC family.
 
 Resolved Issues
 ---------------
-- 
1.9.3

Re: [dpdk-dev] [PATCH 2/2 v2] fm10k: update doc for Atwood Channel

[Thomas Monjalon]

Hi Michael,

2016-02-04 16:36, Michael Qiu:
> Atwood Channel is 25GbE NIC and belongs to Intel FM10K family,
> update the doc for it.
> 
> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> Acked-by: John McNamara <john.mcnamara@intel.com>

Next time, it would be better to send the doc changes and the related code
changes in the same patch. Thanks

Re: [dpdk-dev] [PATCH 2/2 v2] fm10k: update doc for Atwood Channel

[Qiu, Michael]

On 2/4/2016 5:05 PM, Thomas Monjalon wrote:
> Hi Michael,
>
> 2016-02-04 16:36, Michael Qiu:
>> Atwood Channel is 25GbE NIC and belongs to Intel FM10K family,
>> update the doc for it.
>>
>> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
>> Acked-by: John McNamara <john.mcnamara@intel.com>
> Next time, it would be better to send the doc changes and the related code
> changes in the same patch. Thanks

OK, I will do it next time.

Thanks,
Michael

Re: [dpdk-dev] [PATCH 1/2 v2] fm10k: Add Atwood Channel Support

[Chen, Jing D]

Hi,

Best Regards,
Mark


> -----Original Message-----
> From: Qiu, Michael
> Sent: Thursday, February 04, 2016 4:36 PM
> To: dev@dpdk.org
> Cc: Chen, Jing D; Qiu, Michael
> Subject: [PATCH 1/2 v2] fm10k: Add Atwood Channel Support
> 
> Atwood Channel is intel 25G NIC, and this patch add the support
> in DPDK.
> 
> Signed-off-by: Michael Qiu<michael.qiu@intel.com>
> Acked-by: John McNamara <john.mcnamara@intel.com>
Acked-by: Jing Chen <jing.d.chen@intel.com>

Re: [dpdk-dev] [PATCH 1/2 v2] fm10k: Add Atwood Channel Support

[Liu, Yong]

Tested-by: Marvin Liu <yong.liu@intel.com>

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michael Qiu
> Sent: Thursday, February 04, 2016 4:36 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH 1/2 v2] fm10k: Add Atwood Channel Support
> 
> Atwood Channel is intel 25G NIC, and this patch add the support
> in DPDK.
> 
> Signed-off-by: Michael Qiu<michael.qiu@intel.com>
> Acked-by: John McNamara <john.mcnamara@intel.com>
> ---
>  drivers/net/fm10k/base/fm10k_osdep.h            | 4 ++++
>  lib/librte_eal/common/include/rte_pci_dev_ids.h | 2 ++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/drivers/net/fm10k/base/fm10k_osdep.h
> b/drivers/net/fm10k/base/fm10k_osdep.h
> index 6852ef0..9cb46ff 100644
> --- a/drivers/net/fm10k/base/fm10k_osdep.h
> +++ b/drivers/net/fm10k/base/fm10k_osdep.h
> @@ -48,6 +48,10 @@ POSSIBILITY OF SUCH DAMAGE.
>  #define BOULDER_RAPIDS_HW
>  #endif
> 
> +#ifndef ATWOOD_CHANNEL_HW
> +#define ATWOOD_CHANNEL_HW
> +#endif
> +
>  #define STATIC                  static
>  #define DEBUGFUNC(F)            DEBUGOUT(F "\n");
>  #define DEBUGOUT(S, args...)    PMD_DRV_LOG_RAW(DEBUG, S, ##args)
> diff --git a/lib/librte_eal/common/include/rte_pci_dev_ids.h
> b/lib/librte_eal/common/include/rte_pci_dev_ids.h
> index e31b934..cb0d177 100644
> --- a/lib/librte_eal/common/include/rte_pci_dev_ids.h
> +++ b/lib/librte_eal/common/include/rte_pci_dev_ids.h
> @@ -530,9 +530,11 @@ RTE_PCI_DEV_ID_DECL_I40E(PCI_VENDOR_ID_INTEL,
> I40E_DEV_ID_10G_BASE_T_X722)
> 
>  #define FM10K_DEV_ID_PF                   0x15A4
>  #define FM10K_DEV_ID_SDI_FM10420_QDA2     0x15D0
> +#define FM10K_DEV_ID_SDI_FM10420_DA2      0x15D5
> 
>  RTE_PCI_DEV_ID_DECL_FM10K(PCI_VENDOR_ID_INTEL, FM10K_DEV_ID_PF)
>  RTE_PCI_DEV_ID_DECL_FM10K(PCI_VENDOR_ID_INTEL,
> FM10K_DEV_ID_SDI_FM10420_QDA2)
> +RTE_PCI_DEV_ID_DECL_FM10K(PCI_VENDOR_ID_INTEL,
> FM10K_DEV_ID_SDI_FM10420_DA2)
> 
>  /****************** Virtual IGB devices from e1000_hw.h
> ******************/
> 
> --
> 1.9.3

Re: [dpdk-dev] [PATCH 1/2 v2] fm10k: Add Atwood Channel Support

[Qiu, Michael]

Hi, Bruce

What about this patch?

Thanks,
Michael

On 2/4/2016 4:36 PM, Qiu, Michael wrote:
> Atwood Channel is intel 25G NIC, and this patch add the support
> in DPDK.
>
> Signed-off-by: Michael Qiu<michael.qiu@intel.com>
> Acked-by: John McNamara <john.mcnamara@intel.com>
> ---
>  drivers/net/fm10k/base/fm10k_osdep.h            | 4 ++++
>  lib/librte_eal/common/include/rte_pci_dev_ids.h | 2 ++
>  2 files changed, 6 insertions(+)
>
> diff --git a/drivers/net/fm10k/base/fm10k_osdep.h b/drivers/net/fm10k/base/fm10k_osdep.h
> index 6852ef0..9cb46ff 100644
> --- a/drivers/net/fm10k/base/fm10k_osdep.h
> +++ b/drivers/net/fm10k/base/fm10k_osdep.h
> @@ -48,6 +48,10 @@ POSSIBILITY OF SUCH DAMAGE.
>  #define BOULDER_RAPIDS_HW
>  #endif
>  
> +#ifndef ATWOOD_CHANNEL_HW
> +#define ATWOOD_CHANNEL_HW
> +#endif
> +
>  #define STATIC                  static
>  #define DEBUGFUNC(F)            DEBUGOUT(F "\n");
>  #define DEBUGOUT(S, args...)    PMD_DRV_LOG_RAW(DEBUG, S, ##args)
> diff --git a/lib/librte_eal/common/include/rte_pci_dev_ids.h b/lib/librte_eal/common/include/rte_pci_dev_ids.h
> index e31b934..cb0d177 100644
> --- a/lib/librte_eal/common/include/rte_pci_dev_ids.h
> +++ b/lib/librte_eal/common/include/rte_pci_dev_ids.h
> @@ -530,9 +530,11 @@ RTE_PCI_DEV_ID_DECL_I40E(PCI_VENDOR_ID_INTEL, I40E_DEV_ID_10G_BASE_T_X722)
>  
>  #define FM10K_DEV_ID_PF                   0x15A4
>  #define FM10K_DEV_ID_SDI_FM10420_QDA2     0x15D0
> +#define FM10K_DEV_ID_SDI_FM10420_DA2      0x15D5
>  
>  RTE_PCI_DEV_ID_DECL_FM10K(PCI_VENDOR_ID_INTEL, FM10K_DEV_ID_PF)
>  RTE_PCI_DEV_ID_DECL_FM10K(PCI_VENDOR_ID_INTEL, FM10K_DEV_ID_SDI_FM10420_QDA2)
> +RTE_PCI_DEV_ID_DECL_FM10K(PCI_VENDOR_ID_INTEL, FM10K_DEV_ID_SDI_FM10420_DA2)
>  
>  /****************** Virtual IGB devices from e1000_hw.h ******************/
>