Re: [dpdk-dev] [PATCH v3 1/7] cmdline: make implementation logically opaque

["Kinsella, Ray" <mdr@ashroe.eu>]

On 28/09/2020 22:50, Dmitry Kozlyuk wrote:
> struct cmdline exposes platform-specific members it contains, most
> notably struct termios that is only available on Unix. While ABI
> considerations prevent from hinding the definition on already supported
> platforms, struct cmdline is considered logically opaque from now on.
> Add a deprecation notice targeted at 20.11.
> 
> * Remove tests checking struct cmdline content as meaningless.
> 
> * Fix missing cmdline_free() in unit test.
> 
> * Add cmdline_get_rdline() to access history buffer indirectly.
>   The new function is currently used only in tests.
> 
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> Suggested-by: Olivier Matz <olivier.matz@6wind.com>
> ---
>  app/test-cmdline/commands.c                |  8 +++-
>  app/test/test_cmdline_lib.c                | 44 +++++++++-------------
>  doc/guides/rel_notes/deprecation.rst       |  4 ++
>  lib/librte_cmdline/cmdline.c               |  9 +++--
>  lib/librte_cmdline/cmdline.h               | 18 ++++++++-
>  lib/librte_cmdline/cmdline_parse.c         |  3 --
>  lib/librte_cmdline/cmdline_socket.c        |  5 +--
>  lib/librte_cmdline/rte_cmdline_version.map |  8 ++++
>  8 files changed, 60 insertions(+), 39 deletions(-)

Acked-by: Ray Kinsella <mdr@ashroe.eu>