From: Vincent JARDIN <vincent.jardin@6wind.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] virtio: prettify log messages
Date: Thu, 11 Feb 2016 00:45:34 +0100 [thread overview]
Message-ID: <1455147934-15060-1-git-send-email-vincent.jardin@6wind.com> (raw)
PMD_TX_LOG() looks better with a \n
Signed-off-by: Vincent JARDIN <vincent.jardin@6wind.com>
---
drivers/net/virtio/virtio_rxtx.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c
index 41a1366..c03d36a 100644
--- a/drivers/net/virtio/virtio_rxtx.c
+++ b/drivers/net/virtio/virtio_rxtx.c
@@ -825,7 +825,7 @@ virtio_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
if (unlikely(nb_pkts < 1))
return nb_pkts;
- PMD_TX_LOG(DEBUG, "%d packets to xmit", nb_pkts);
+ PMD_TX_LOG(DEBUG, "%d packets to xmit\n", nb_pkts);
nb_used = VIRTQUEUE_NUSED(txvq);
virtio_rmb();
@@ -847,7 +847,7 @@ virtio_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
need = txm->nb_segs - txvq->vq_free_cnt + 1;
if (unlikely(need > 0)) {
PMD_TX_LOG(ERR,
- "No free tx descriptors to transmit");
+ "No free tx descriptors to transmit\n");
break;
}
}
@@ -865,11 +865,11 @@ virtio_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
error = virtqueue_enqueue_xmit(txvq, txm);
if (unlikely(error)) {
if (error == ENOSPC)
- PMD_TX_LOG(ERR, "virtqueue_enqueue Free count = 0");
+ PMD_TX_LOG(ERR, "virtqueue_enqueue Free count = 0\n");
else if (error == EMSGSIZE)
- PMD_TX_LOG(ERR, "virtqueue_enqueue Free count < 1");
+ PMD_TX_LOG(ERR, "virtqueue_enqueue Free count < 1\n");
else
- PMD_TX_LOG(ERR, "virtqueue_enqueue error: %d", error);
+ PMD_TX_LOG(ERR, "virtqueue_enqueue error: %d\n", error);
break;
}
@@ -884,7 +884,7 @@ virtio_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
if (unlikely(virtqueue_kick_prepare(txvq))) {
virtqueue_notify(txvq);
- PMD_TX_LOG(DEBUG, "Notified backend after xmit");
+ PMD_TX_LOG(DEBUG, "Notified backend after xmit\n");
}
}
--
2.1.0
next reply other threads:[~2016-02-10 23:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 23:45 Vincent JARDIN [this message]
2016-02-11 1:12 ` Stephen Hemminger
2016-02-11 6:45 ` Vincent JARDIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455147934-15060-1-git-send-email-vincent.jardin@6wind.com \
--to=vincent.jardin@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).