DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] virtio: prettify log messages
@ 2016-02-10 23:45 Vincent JARDIN
  2016-02-11  1:12 ` Stephen Hemminger
  0 siblings, 1 reply; 3+ messages in thread
From: Vincent JARDIN @ 2016-02-10 23:45 UTC (permalink / raw)
  To: dev

PMD_TX_LOG() looks better with a \n

Signed-off-by: Vincent JARDIN <vincent.jardin@6wind.com>
---
 drivers/net/virtio/virtio_rxtx.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c
index 41a1366..c03d36a 100644
--- a/drivers/net/virtio/virtio_rxtx.c
+++ b/drivers/net/virtio/virtio_rxtx.c
@@ -825,7 +825,7 @@ virtio_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
 	if (unlikely(nb_pkts < 1))
 		return nb_pkts;
 
-	PMD_TX_LOG(DEBUG, "%d packets to xmit", nb_pkts);
+	PMD_TX_LOG(DEBUG, "%d packets to xmit\n", nb_pkts);
 	nb_used = VIRTQUEUE_NUSED(txvq);
 
 	virtio_rmb();
@@ -847,7 +847,7 @@ virtio_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
 			need = txm->nb_segs - txvq->vq_free_cnt + 1;
 			if (unlikely(need > 0)) {
 				PMD_TX_LOG(ERR,
-					   "No free tx descriptors to transmit");
+					   "No free tx descriptors to transmit\n");
 				break;
 			}
 		}
@@ -865,11 +865,11 @@ virtio_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
 		error = virtqueue_enqueue_xmit(txvq, txm);
 		if (unlikely(error)) {
 			if (error == ENOSPC)
-				PMD_TX_LOG(ERR, "virtqueue_enqueue Free count = 0");
+				PMD_TX_LOG(ERR, "virtqueue_enqueue Free count = 0\n");
 			else if (error == EMSGSIZE)
-				PMD_TX_LOG(ERR, "virtqueue_enqueue Free count < 1");
+				PMD_TX_LOG(ERR, "virtqueue_enqueue Free count < 1\n");
 			else
-				PMD_TX_LOG(ERR, "virtqueue_enqueue error: %d", error);
+				PMD_TX_LOG(ERR, "virtqueue_enqueue error: %d\n", error);
 			break;
 		}
 
@@ -884,7 +884,7 @@ virtio_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
 
 		if (unlikely(virtqueue_kick_prepare(txvq))) {
 			virtqueue_notify(txvq);
-			PMD_TX_LOG(DEBUG, "Notified backend after xmit");
+			PMD_TX_LOG(DEBUG, "Notified backend after xmit\n");
 		}
 	}
 
-- 
2.1.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-02-11  6:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-10 23:45 [dpdk-dev] [PATCH] virtio: prettify log messages Vincent JARDIN
2016-02-11  1:12 ` Stephen Hemminger
2016-02-11  6:45   ` Vincent JARDIN

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).