From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout4.w1.samsung.com (mailout4.w1.samsung.com [210.118.77.14]) by dpdk.org (Postfix) with ESMTP id 43E67C4C4 for ; Fri, 19 Feb 2016 11:56:52 +0100 (CET) Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O2S004OMJQR1I20@mailout4.w1.samsung.com> for dev@dpdk.org; Fri, 19 Feb 2016 10:56:51 +0000 (GMT) X-AuditID: cbfec7f5-f79b16d000005389-61-56c6f4f26d8b Received: from eusync4.samsung.com ( [203.254.199.214]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id F5.B1.21385.2F4F6C65; Fri, 19 Feb 2016 10:56:50 +0000 (GMT) Received: from imaximets.rnd.samsung.ru ([106.109.129.180]) by eusync4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0O2S001Z8JQJEA80@eusync4.samsung.com>; Fri, 19 Feb 2016 10:56:50 +0000 (GMT) From: Ilya Maximets To: dev@dpdk.org, Huawei Xie , Yuanhan Liu Date: Fri, 19 Feb 2016 13:56:38 +0300 Message-id: <1455879400-17827-2-git-send-email-i.maximets@samsung.com> X-Mailer: git-send-email 2.5.0 In-reply-to: <1455879400-17827-1-git-send-email-i.maximets@samsung.com> References: <1455879400-17827-1-git-send-email-i.maximets@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprKLMWRmVeSWpSXmKPExsVy+t/xa7qfvhwLM/h+19ji3aftTBbtM88y WVxp/8luMXGSicX0pxEWk2dLWVyfcIHVgd1jw4l+Vo9fC5ayeize85LJ4861PWwe804GevRt WcUYwBbFZZOSmpNZllqkb5fAlTFzxjHWgibuip6Xc1kaGHs5uxg5OSQETCQ+TdnFDmGLSVy4 t56ti5GLQ0hgKaPEqe4nzCAJIYFWJoldv+xBbDYBHYlTq48wgtgiAgkSR/b/ZgVpYBZYxihx 8cRkJpCEsICvxOZpq8CaWQRUJT6v6mEFsXkF3CT2n/kNFOcA2iYnseBCOkiYU8Bd4v+PL+wQ u9wkZrw/xziBkXcBI8MqRtHU0uSC4qT0XCO94sTc4tK8dL3k/NxNjJDA+rqDcekxq0OMAhyM Sjy8FXrHwoRYE8uKK3MPMUpwMCuJ8Na+AgrxpiRWVqUW5ccXleakFh9ilOZgURLnnbnrfYiQ QHpiSWp2ampBahFMlomDU6qBMTaAPTlccKGn1qM18su6f7Llm308zHS2wM+3f8/m09PtZq7v fr87YVvA2YVz35laWQZHlukd2qGyMHyL4v7up3G1ySv2WbXd+X7+wrpDnpPSWU3/2C/YMKFR sWfBly9hL2X6dPUuxiQ0bZpwqeve+uPR+uJTvm+r04jp2P5nqt6///Gz2PpWOyuxFGckGmox FxUnAgAD9lRsKAIAAA== Cc: Ilya Maximets , Dyasly Sergey Subject: [dpdk-dev] [PATCH RFC v2 1/3] vhost: use SMP barriers instead of compiler ones. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2016 10:56:52 -0000 Since commit 4c02e453cc62 ("eal: introduce SMP memory barriers") virtio uses architecture dependent SMP barriers. vHost should use them too. Fixes: 4c02e453cc62 ("eal: introduce SMP memory barriers") Signed-off-by: Ilya Maximets --- lib/librte_vhost/vhost_rxtx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_vhost/vhost_rxtx.c b/lib/librte_vhost/vhost_rxtx.c index 5e7e5b1..411dd95 100644 --- a/lib/librte_vhost/vhost_rxtx.c +++ b/lib/librte_vhost/vhost_rxtx.c @@ -274,7 +274,7 @@ virtio_dev_rx(struct virtio_net *dev, uint16_t queue_id, } } - rte_compiler_barrier(); + rte_smp_wmb(); /* Wait until it's our turn to add our buffer to the used ring. */ while (unlikely(vq->last_used_idx != res_base_idx)) @@ -575,7 +575,7 @@ virtio_dev_merge_rx(struct virtio_net *dev, uint16_t queue_id, entry_success = copy_from_mbuf_to_vring(dev, queue_id, res_base_idx, res_cur_idx, pkts[pkt_idx]); - rte_compiler_barrier(); + rte_smp_wmb(); /* * Wait until it's our turn to add our buffer @@ -917,7 +917,7 @@ rte_vhost_dequeue_burst(struct virtio_net *dev, uint16_t queue_id, entry_success++; } - rte_compiler_barrier(); + rte_smp_rmb(); vq->used->idx += entry_success; /* Kick guest if required. */ if (!(vq->avail->flags & VRING_AVAIL_F_NO_INTERRUPT)) -- 2.5.0