[dpdk-dev] [PATCH] cmdline: include missing cmdline_parse.h

[dpdk-dev] [PATCH] cmdline: include missing cmdline_parse.h

[Marc Sune]

cmdline_parse_*.h headers use struct cmdline_token_hdr /
cmdline_parse_token_hdr_t which is defined in cmdline_parse.h, but
do not include it, forcing manual inclusion.

This commit includes cmdline_parse.h in all cmdline_parse_*.h.
---
 lib/librte_cmdline/cmdline_parse_etheraddr.h | 2 ++
 lib/librte_cmdline/cmdline_parse_ipaddr.h    | 1 +
 lib/librte_cmdline/cmdline_parse_num.h       | 2 ++
 lib/librte_cmdline/cmdline_parse_portlist.h  | 2 ++
 lib/librte_cmdline/cmdline_parse_string.h    | 2 ++
 5 files changed, 9 insertions(+)

diff --git a/lib/librte_cmdline/cmdline_parse_etheraddr.h b/lib/librte_cmdline/cmdline_parse_etheraddr.h
index 0085bb3..e539fb6 100644
--- a/lib/librte_cmdline/cmdline_parse_etheraddr.h
+++ b/lib/librte_cmdline/cmdline_parse_etheraddr.h
@@ -61,6 +61,8 @@
 #ifndef _PARSE_ETHERADDR_H_
 #define _PARSE_ETHERADDR_H_
 
+#include <cmdline_parse.h>
+
 #ifdef __cplusplus
 extern "C" {
 #endif
diff --git a/lib/librte_cmdline/cmdline_parse_ipaddr.h b/lib/librte_cmdline/cmdline_parse_ipaddr.h
index 46c6e1b..2b4266f 100644
--- a/lib/librte_cmdline/cmdline_parse_ipaddr.h
+++ b/lib/librte_cmdline/cmdline_parse_ipaddr.h
@@ -61,6 +61,7 @@
 #ifndef _PARSE_IPADDR_H_
 #define _PARSE_IPADDR_H_
 
+#include <cmdline_parse.h>
 #include <netinet/in.h>
 
 #ifdef __cplusplus
diff --git a/lib/librte_cmdline/cmdline_parse_num.h b/lib/librte_cmdline/cmdline_parse_num.h
index 5376806..2558cbf 100644
--- a/lib/librte_cmdline/cmdline_parse_num.h
+++ b/lib/librte_cmdline/cmdline_parse_num.h
@@ -61,6 +61,8 @@
 #ifndef _PARSE_NUM_H_
 #define _PARSE_NUM_H_
 
+#include <cmdline_parse.h>
+
 #ifdef __cplusplus
 extern "C" {
 #endif
diff --git a/lib/librte_cmdline/cmdline_parse_portlist.h b/lib/librte_cmdline/cmdline_parse_portlist.h
index 8505059..73d70e0 100644
--- a/lib/librte_cmdline/cmdline_parse_portlist.h
+++ b/lib/librte_cmdline/cmdline_parse_portlist.h
@@ -61,6 +61,8 @@
 #ifndef _PARSE_PORTLIST_H_
 #define _PARSE_PORTLIST_H_
 
+#include <cmdline_parse.h>
+
 #ifdef __cplusplus
 extern "C" {
 #endif
diff --git a/lib/librte_cmdline/cmdline_parse_string.h b/lib/librte_cmdline/cmdline_parse_string.h
index c205622..94aa1f1 100644
--- a/lib/librte_cmdline/cmdline_parse_string.h
+++ b/lib/librte_cmdline/cmdline_parse_string.h
@@ -61,6 +61,8 @@
 #ifndef _PARSE_STRING_H_
 #define _PARSE_STRING_H_
 
+#include <cmdline_parse.h>
+
 #ifdef __cplusplus
 extern "C" {
 #endif
-- 
2.1.4

Re: [dpdk-dev] [PATCH] cmdline: include missing cmdline_parse.h

[Olivier MATZ]

Hi Marc,

On 03/03/2016 12:52 AM, Marc Sune wrote:
> cmdline_parse_*.h headers use struct cmdline_token_hdr /
> cmdline_parse_token_hdr_t which is defined in cmdline_parse.h, but
> do not include it, forcing manual inclusion.
> 
> This commit includes cmdline_parse.h in all cmdline_parse_*.h.

Acked-by: Olivier Matz <olivier.matz@6wind.com>

Thanks

Re: [dpdk-dev] [PATCH] cmdline: include missing cmdline_parse.h

[Thomas Monjalon]

2016-03-04 10:05, Olivier MATZ:
> Hi Marc,
> 
> On 03/03/2016 12:52 AM, Marc Sune wrote:
> > cmdline_parse_*.h headers use struct cmdline_token_hdr /
> > cmdline_parse_token_hdr_t which is defined in cmdline_parse.h, but
> > do not include it, forcing manual inclusion.
> > 
> > This commit includes cmdline_parse.h in all cmdline_parse_*.h.
> 
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
> 
> Thanks

Applied, thanks