DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bernard Iremonger <bernard.iremonger@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v4 1/3] ixgbe: cleanup eth_ixgbevf_dev_uninit
Date: Tue,  8 Mar 2016 17:10:25 +0000	[thread overview]
Message-ID: <1457457027-21419-2-git-send-email-bernard.iremonger@intel.com> (raw)
In-Reply-To: <1457457027-21419-1-git-send-email-bernard.iremonger@intel.com>

Releasing the rx and tx queues is already done in ixgbe_dev_close()
so it does not need to be done in eth_ixgbevf_dev_uninit().

Fixes: 2866c5f1b87e ("ixgbe: support port hotplug")

Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 15 +--------------
 1 file changed, 1 insertion(+), 14 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 3e6fe86..0db7f51 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -1,7 +1,7 @@
 /*-
  *   BSD LICENSE
  *
- *   Copyright(c) 2010-2015 Intel Corporation. All rights reserved.
+ *   Copyright(c) 2010-2016 Intel Corporation. All rights reserved.
  *   All rights reserved.
  *
  *   Redistribution and use in source and binary forms, with or without
@@ -1390,7 +1390,6 @@ static int
 eth_ixgbevf_dev_uninit(struct rte_eth_dev *eth_dev)
 {
 	struct ixgbe_hw *hw;
-	unsigned i;
 
 	PMD_INIT_FUNC_TRACE();
 
@@ -1409,18 +1408,6 @@ eth_ixgbevf_dev_uninit(struct rte_eth_dev *eth_dev)
 	/* Disable the interrupts for VF */
 	ixgbevf_intr_disable(hw);
 
-	for (i = 0; i < eth_dev->data->nb_rx_queues; i++) {
-		ixgbe_dev_rx_queue_release(eth_dev->data->rx_queues[i]);
-		eth_dev->data->rx_queues[i] = NULL;
-	}
-	eth_dev->data->nb_rx_queues = 0;
-
-	for (i = 0; i < eth_dev->data->nb_tx_queues; i++) {
-		ixgbe_dev_tx_queue_release(eth_dev->data->tx_queues[i]);
-		eth_dev->data->tx_queues[i] = NULL;
-	}
-	eth_dev->data->nb_tx_queues = 0;
-
 	rte_free(eth_dev->data->mac_addrs);
 	eth_dev->data->mac_addrs = NULL;
 
-- 
2.6.3

  reply	other threads:[~2016-03-08 17:10 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-24 16:19 [dpdk-dev] [PATCH 0/3] ixgbe fixes Bernard Iremonger
2016-02-24 16:19 ` [dpdk-dev] [PATCH 1/3] ixgbe: cleanup eth_ixgbevf_dev_uninit Bernard Iremonger
2016-02-24 16:19 ` [dpdk-dev] [PATCH 2/3] ixgbe: add more information to the error message Bernard Iremonger
2016-02-24 16:19 ` [dpdk-dev] [PATCH 3/3] ixgbe: allow use of zero MAC address with VF Bernard Iremonger
2016-02-26 14:49 ` [dpdk-dev] [PATCH 0/3 v2] ixgbe fixes Bernard Iremonger
2016-02-26 14:49   ` [dpdk-dev] [PATCH 1/3 v2] ixgbe: cleanup eth_ixgbevf_dev_uninit Bernard Iremonger
2016-02-26 14:49   ` [dpdk-dev] [PATCH 2/3 v2] ixgbe: add more information to the error message Bernard Iremonger
2016-02-26 14:49   ` [dpdk-dev] [PATCH 3/3 v2] ixgbe: fix setting of VF MAC address Bernard Iremonger
2016-02-29 17:03   ` [dpdk-dev] [PATCH 0/3 v2] ixgbe fixes Ananyev, Konstantin
2016-03-07 17:38   ` [dpdk-dev] [PATCH v3 0/3] " Bernard Iremonger
2016-03-07 17:38     ` [dpdk-dev] [PATCH v3 1/3] ixgbe: cleanup eth_ixgbevf_dev_uninit Bernard Iremonger
2016-03-07 17:38     ` [dpdk-dev] [PATCH v3 2/3] ixgbe: add more information to the error message Bernard Iremonger
2016-03-07 17:38     ` [dpdk-dev] [PATCH v3 3/3] ixgbe: fix dev_close to remove VF MAC address Bernard Iremonger
2016-03-08 17:10     ` [dpdk-dev] [PATCH v4 0/3] ixgbe fixes Bernard Iremonger
2016-03-08 17:10       ` Bernard Iremonger [this message]
2016-03-08 17:10       ` [dpdk-dev] [PATCH v4 2/3] ixgbe: add more information to the error message Bernard Iremonger
2016-03-08 17:10       ` [dpdk-dev] [PATCH v4 3/3] ixgbe: fix dev_close to remove VF MAC address Bernard Iremonger
2016-03-09 13:17         ` Ananyev, Konstantin
2016-03-11 17:19       ` [dpdk-dev] [PATCH v4 0/3] ixgbe fixes Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1457457027-21419-2-git-send-email-bernard.iremonger@intel.com \
    --to=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).