DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jan Viktorin <viktorin@rehivetech.com>
To: dev@dpdk.org
Cc: Jan Viktorin <viktorin@rehivetech.com>,
	thomas.monjalon@6wind.com, jerin.jacob@caviumnetworks.com,
	tomaszx.kulasek@intel.com, jianbo.liu@linaro.org,
	david.marchand@6wind.com
Subject: [dpdk-dev] [PATCH v3 0/4] arm: detect NEON by RTE_MACHINE_CPUFLAG_NEON flag only
Date: Sat, 19 Mar 2016 20:58:01 +0100	[thread overview]
Message-ID: <1458417485-29436-1-git-send-email-viktorin@rehivetech.com> (raw)
In-Reply-To: <1458379590-18618-1-git-send-email-viktorin@rehivetech.com>

Hello,

finally, I've broken the original patch into 4 pieces as it solves more issues
and not just a single one.

* As Thomas have already mentioned, the CONFIG_RTE_ARCH_ARM_NEON is confusing. 
  So, I've decided to remove it entirely and provide another option for a more
  specific purpose: CONFIG_RTE_ARCH_ARM_NEON_MEMCPY.

* The RTE_MACHINE_CPUFLAG_NEON detection is now based on __ARM_NEON as only
  this compiler definition gives us the arm_neon.h and is compatible with
  arm64. In DPDK, the RTE_MACHINE_CPUFLAG_NEON should be prefered over the
  __ARM_NEON. I'd recommend the same for x86 code (__SSE2__)... 

History:
v2
* fix l3fwm_em.c to refer RTE_MACHINE_CPUFLAG_NEON instead of __ARM_NEON

v3
* divided into 4 patches as there are more independent problems
* compiles well for armv7
* (probably) fixes RTE_MACHINE_CPUFLAG_NEON detection on arm64

Jan Viktorin (4):
  arm: remove CONFIG_RTE_ARCH_ARM_NEON
  arm: detect NEON cpu feature by checking __ARM_NEON
  arm: detect NEON by checking RTE_MACHINE_CPUFLAG_NEON
  eal/arm: introduce CONFIG_RTE_ARCH_ARM_NEON_MEMCPY

 config/defconfig_arm-armv7a-linuxapp-gcc               | 2 +-
 config/defconfig_arm64-armv8a-linuxapp-gcc             | 1 -
 examples/l3fwd/l3fwd_em.c                              | 2 +-
 lib/librte_eal/common/include/arch/arm/rte_memcpy_32.h | 8 ++++++--
 mk/machine/armv7a/rte.vars.mk                          | 2 --
 mk/rte.cpuflags.mk                                     | 2 +-
 6 files changed, 9 insertions(+), 8 deletions(-)

-- 
2.7.0

  parent reply	other threads:[~2016-03-19 19:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-19  9:26 [dpdk-dev] [PATCH v2] " Jan Viktorin
2016-03-19 11:05 ` Jan Viktorin
2016-03-19 19:58 ` Jan Viktorin [this message]
2016-03-24 16:47   ` [dpdk-dev] [PATCH v3 0/4] " Thomas Monjalon
2016-03-19 19:58 ` [dpdk-dev] [PATCH v3 1/4] arm: remove CONFIG_RTE_ARCH_ARM_NEON Jan Viktorin
2016-03-19 19:58 ` [dpdk-dev] [PATCH v3 2/4] arm: detect NEON cpu feature by checking __ARM_NEON Jan Viktorin
2016-03-20 17:27   ` Jerin Jacob
2016-03-19 19:58 ` [dpdk-dev] [PATCH v3 3/4] arm: detect NEON by checking RTE_MACHINE_CPUFLAG_NEON Jan Viktorin
2016-03-19 19:58 ` [dpdk-dev] [PATCH v3 4/4] eal/arm: introduce CONFIG_RTE_ARCH_ARM_NEON_MEMCPY Jan Viktorin
2016-03-19 20:14   ` Thomas Monjalon
2016-03-20  9:41     ` Jan Viktorin
2016-03-20  9:46       ` Jan Viktorin
2016-03-20 10:33         ` Thomas Monjalon
2016-03-20 10:29       ` Thomas Monjalon
2016-03-20 17:38         ` Jerin Jacob
2016-03-21  5:42   ` Jianbo Liu
2016-03-21 12:21     ` Jan Viktorin
2016-03-21 13:24       ` Thomas Monjalon
2016-03-21 14:01         ` Jan Viktorin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458417485-29436-1-git-send-email-viktorin@rehivetech.com \
    --to=viktorin@rehivetech.com \
    --cc=david.marchand@6wind.com \
    --cc=dev@dpdk.org \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=jianbo.liu@linaro.org \
    --cc=thomas.monjalon@6wind.com \
    --cc=tomaszx.kulasek@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).