From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <aconole@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
by dpdk.org (Postfix) with ESMTP id 8DCD35599
for <dev@dpdk.org>; Tue, 22 Mar 2016 22:37:21 +0100 (CET)
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
by mx1.redhat.com (Postfix) with ESMTPS id 0705880500;
Tue, 22 Mar 2016 21:37:21 +0000 (UTC)
Received: from aconole-fed23.bos.redhat.com (dhcp-25-231.bos.redhat.com
[10.18.25.231])
by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
u2MLbIwO018304; Tue, 22 Mar 2016 17:37:20 -0400
From: Aaron Conole <aconole@redhat.com>
To: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>,
Helin Zhang <helin.zhang@intel.com>, Wenzhuo Lu <wenzhou.lu@intel.com>,
Panu Matilainen <pmatilai@redhat.com>, Remy Horton <remy.horton@intel.com>
Date: Tue, 22 Mar 2016 17:37:12 -0400
Message-Id: <1458682638-28378-2-git-send-email-aconole@redhat.com>
In-Reply-To: <1458682638-28378-1-git-send-email-aconole@redhat.com>
References: <1458682638-28378-1-git-send-email-aconole@redhat.com>
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26
Subject: [dpdk-dev] [PATCH v2 1/7] app/test/test: Fix missing brackets
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Mar 2016 21:37:21 -0000
The test application calls printf(...) with the suite->suite_name argument.
The intent (based on whitespace) in the printf is to check suite->suite_name
first and then apply the printf. This doesn't happen due to missing brackets.
Signed-off-by: Aaron Conole <aconole@redhat.com>
Acked-by: Panu Matilainen <pmatilai@redhat.com>
---
v2:
* No change (apart from adding ACKs)
app/test/test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/app/test/test.c b/app/test/test.c
index f35b304..ccad0e3 100644
--- a/app/test/test.c
+++ b/app/test/test.c
@@ -162,9 +162,10 @@ unit_test_suite_runner(struct unit_test_suite *suite)
int test_success;
unsigned total = 0, executed = 0, skipped = 0, succeeded = 0, failed = 0;
- if (suite->suite_name)
+ if (suite->suite_name) {
printf(" + ------------------------------------------------------- +\n");
printf(" + Test Suite : %s\n", suite->suite_name);
+ }
if (suite->setup)
if (suite->setup() != 0)
--
2.8.0.rc2.35.gc2c5f6b.dirty