DPDK patches and discussions
 help / color / mirror / Atom feed
From: Wenzhuo Lu <wenzhuo.lu@intel.com>
To: dev@dpdk.org
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>
Subject: [dpdk-dev] [PATCH 1/2] ixgbe: fix the wrong address of device data pointer
Date: Thu, 24 Mar 2016 14:37:10 +0800	[thread overview]
Message-ID: <1458801431-25886-2-git-send-email-wenzhuo.lu@intel.com> (raw)
In-Reply-To: <1458801431-25886-1-git-send-email-wenzhuo.lu@intel.com>

There's an issue reported. In the scenario DPDK PF + DPDK VF,
if the VF port is closed, PF port cannot receive packets.
I found at that time the promicuous mode is disabled on the PF
port. But it should be enabled.
When VF port is closed, it will send a message to its PF port to
reset it. During this, PF port will also reset its own
promicuous mode. Which promiscuous mode should be set depends on
the parameter stored in the device data. In the function
set_rx_mode, the pointer of device data points to the wrong
address. So, the promiscuous mode is wrong.

Fixes: 00e30184daa0("ixgbe: add PF support")
Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Reported-by: Bernard Iremonger <bernard.iremonger@intel.com>
---
 drivers/net/ixgbe/ixgbe_pf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c
index b854c72..0f8ad55 100644
--- a/drivers/net/ixgbe/ixgbe_pf.c
+++ b/drivers/net/ixgbe/ixgbe_pf.c
@@ -313,7 +313,7 @@ static void
 set_rx_mode(struct rte_eth_dev *dev)
 {
 	struct rte_eth_dev_data *dev_data =
-		(struct rte_eth_dev_data*)dev->data->dev_private;
+		(struct rte_eth_dev_data *)dev->data;
 	struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
 	u32 fctrl, vmolr = IXGBE_VMOLR_BAM | IXGBE_VMOLR_AUPE;
 	uint16_t vfn = dev_num_vf(dev);
-- 
1.9.3

  reply	other threads:[~2016-03-24  6:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-24  6:37 [dpdk-dev] [PATCH 0/2] " Wenzhuo Lu
2016-03-24  6:37 ` Wenzhuo Lu [this message]
2016-03-24  6:48   ` [dpdk-dev] [PATCH 1/2] ixgbe: " Wu, Jingjing
2016-03-24  6:53     ` Lu, Wenzhuo
2016-03-24  6:37 ` [dpdk-dev] [PATCH 2/2] igb: " Wenzhuo Lu
2016-03-24  7:07 ` [dpdk-dev] [PATCH v2 0/2] " Wenzhuo Lu
2016-03-24  7:07   ` [dpdk-dev] [PATCH v2 1/2] ixgbe: " Wenzhuo Lu
2016-03-24  7:14     ` Wu, Jingjing
2016-03-24  7:07   ` [dpdk-dev] [PATCH v2 2/2] igb: " Wenzhuo Lu
2016-03-24  7:14     ` Wu, Jingjing
2016-03-24 12:34   ` [dpdk-dev] [PATCH v2 0/2] " Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458801431-25886-2-git-send-email-wenzhuo.lu@intel.com \
    --to=wenzhuo.lu@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).