* [dpdk-dev] [PATCH] hash: fix typo in Doxygen comment
@ 2016-03-24 14:27 Pablo de Lara
2016-03-29 16:03 ` Bruce Richardson
2016-03-29 17:38 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
0 siblings, 2 replies; 4+ messages in thread
From: Pablo de Lara @ 2016-03-24 14:27 UTC (permalink / raw)
To: dev; +Cc: Pablo de Lara
rte_hash_set_cmp_func() had an incorrect Doxygen comment
for one of its parameters.
Fixes: 95da2f8e9c61 ("hash: customize compare function")
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
lib/librte_hash/rte_hash.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_hash/rte_hash.h b/lib/librte_hash/rte_hash.h
index 85fc416..add3414 100644
--- a/lib/librte_hash/rte_hash.h
+++ b/lib/librte_hash/rte_hash.h
@@ -114,7 +114,7 @@ rte_hash_create(const struct rte_hash_parameters *params);
* in multi-process mode.
*
* @param h
- * Hash table to reset
+ * Hash table to change the function
* @param func
* New compare function
*/
--
2.5.5
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] hash: fix typo in Doxygen comment
2016-03-24 14:27 [dpdk-dev] [PATCH] hash: fix typo in Doxygen comment Pablo de Lara
@ 2016-03-29 16:03 ` Bruce Richardson
2016-03-29 17:38 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
1 sibling, 0 replies; 4+ messages in thread
From: Bruce Richardson @ 2016-03-29 16:03 UTC (permalink / raw)
To: Pablo de Lara; +Cc: dev
On Thu, Mar 24, 2016 at 02:27:46PM +0000, Pablo de Lara wrote:
> rte_hash_set_cmp_func() had an incorrect Doxygen comment
> for one of its parameters.
>
> Fixes: 95da2f8e9c61 ("hash: customize compare function")
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> lib/librte_hash/rte_hash.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_hash/rte_hash.h b/lib/librte_hash/rte_hash.h
> index 85fc416..add3414 100644
> --- a/lib/librte_hash/rte_hash.h
> +++ b/lib/librte_hash/rte_hash.h
> @@ -114,7 +114,7 @@ rte_hash_create(const struct rte_hash_parameters *params);
> * in multi-process mode.
> *
> * @param h
> - * Hash table to reset
> + * Hash table to change the function
Good idea to change this. However, to read correctly, I think it might need to
be adjusted slightly. E.g.
* Hash table for which the function is to be changed
* Hash table to update
Regards,
/Bruce
> * @param func
> * New compare function
> */
> --
> 2.5.5
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH v2] hash: fix typo in Doxygen comment
2016-03-24 14:27 [dpdk-dev] [PATCH] hash: fix typo in Doxygen comment Pablo de Lara
2016-03-29 16:03 ` Bruce Richardson
@ 2016-03-29 17:38 ` Pablo de Lara
2016-04-01 12:56 ` Thomas Monjalon
1 sibling, 1 reply; 4+ messages in thread
From: Pablo de Lara @ 2016-03-29 17:38 UTC (permalink / raw)
To: dev; +Cc: bruce.richardson, Pablo de Lara
rte_hash_set_cmp_func() had an incorrect Doxygen comment
for one of its parameters.
Fixes: 95da2f8e9c61 ("hash: customize compare function")
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
Changes in v2:
- Reworded Doxygen comment
lib/librte_hash/rte_hash.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_hash/rte_hash.h b/lib/librte_hash/rte_hash.h
index 85fc416..ae00b65 100644
--- a/lib/librte_hash/rte_hash.h
+++ b/lib/librte_hash/rte_hash.h
@@ -114,7 +114,7 @@ rte_hash_create(const struct rte_hash_parameters *params);
* in multi-process mode.
*
* @param h
- * Hash table to reset
+ * Hash table for which the function is to be changed
* @param func
* New compare function
*/
--
2.5.5
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH v2] hash: fix typo in Doxygen comment
2016-03-29 17:38 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
@ 2016-04-01 12:56 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2016-04-01 12:56 UTC (permalink / raw)
To: Pablo de Lara; +Cc: dev, bruce.richardson
2016-03-29 18:38, Pablo de Lara:
> rte_hash_set_cmp_func() had an incorrect Doxygen comment
> for one of its parameters.
>
> Fixes: 95da2f8e9c61 ("hash: customize compare function")
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-04-01 12:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-24 14:27 [dpdk-dev] [PATCH] hash: fix typo in Doxygen comment Pablo de Lara
2016-03-29 16:03 ` Bruce Richardson
2016-03-29 17:38 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
2016-04-01 12:56 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).