* [dpdk-dev] [PATCH] vhost: fix coverity defect
@ 2016-04-05 6:00 Yuanhan Liu
2016-04-06 10:18 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Yuanhan Liu @ 2016-04-05 6:00 UTC (permalink / raw)
To: dev; +Cc: huawei.xie, Thomas Monjalon, Yuanhan Liu
Fix following coverity defect:
291 void
292 vhost_destroy_device(struct vhost_device_ctx ctx)
293 {
294 struct virtio_net *dev = get_device(ctx);
295
>>> CID 124565: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing a null pointer "dev".
Fixes: 45ca9c6f7bc6 ("vhost: get rid of linked list for devices")
Reported-by: John McNamara <john.mcnamara@intel.com>
Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
---
lib/librte_vhost/virtio-net.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/librte_vhost/virtio-net.c b/lib/librte_vhost/virtio-net.c
index 90da9ba..d870ad9 100644
--- a/lib/librte_vhost/virtio-net.c
+++ b/lib/librte_vhost/virtio-net.c
@@ -293,6 +293,9 @@ vhost_destroy_device(struct vhost_device_ctx ctx)
{
struct virtio_net *dev = get_device(ctx);
+ if (dev == NULL)
+ return;
+
if (dev->flags & VIRTIO_DEV_RUNNING)
notify_ops->destroy_device(dev);
--
1.9.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] vhost: fix coverity defect
2016-04-05 6:00 [dpdk-dev] [PATCH] vhost: fix coverity defect Yuanhan Liu
@ 2016-04-06 10:18 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2016-04-06 10:18 UTC (permalink / raw)
To: Yuanhan Liu; +Cc: dev, huawei.xie
> Fix following coverity defect:
>
> 291 void
> 292 vhost_destroy_device(struct vhost_device_ctx ctx)
> 293 {
> 294 struct virtio_net *dev = get_device(ctx);
> 295
> >>> CID 124565: Null pointer dereferences (NULL_RETURNS)
> >>> Dereferencing a null pointer "dev".
>
> Fixes: 45ca9c6f7bc6 ("vhost: get rid of linked list for devices")
>
> Reported-by: John McNamara <john.mcnamara@intel.com>
> Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-06 10:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-05 6:00 [dpdk-dev] [PATCH] vhost: fix coverity defect Yuanhan Liu
2016-04-06 10:18 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).