DPDK patches and discussions
 help / color / mirror / Atom feed
From: Pablo de Lara <pablo.de.lara.guarch@intel.com>
To: dev@dpdk.org
Cc: sergio.gonzalez.monroy@intel.com,
	Pablo de Lara <pablo.de.lara.guarch@intel.com>
Subject: [dpdk-dev] [PATCH] ipsec-secgw: fix anonymous union initialization
Date: Fri,  8 Apr 2016 18:01:09 +0100	[thread overview]
Message-ID: <1460134869-42603-1-git-send-email-pablo.de.lara.guarch@intel.com> (raw)

In icc 14.0, compilation was broken:

examples/ipsec-secgw/sa.c(212): error: a designator for an anonymous
union member can only appear within braces corresponding to that anonymous union
        .cipher = { RTE_CRYPTO_CIPHER_OP_ENCRYPT, RTE_CRYPTO_CIPHER_AES_CBC,
         ^

The member in anonymous union initialization should be inside '{}',
otherwise it will report an error.

Fixes: d299106e8e31 (examples/ipsec-secgw: add IPsec sample application)

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 examples/ipsec-secgw/sa.c | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c
index a5b8a63..b6260ed 100644
--- a/examples/ipsec-secgw/sa.c
+++ b/examples/ipsec-secgw/sa.c
@@ -209,15 +209,17 @@ static uint8_t cipher_key[256] = "sixteenbytes key";
 const struct rte_crypto_sym_xform aescbc_enc_xf = {
 	NULL,
 	RTE_CRYPTO_SYM_XFORM_CIPHER,
-	.cipher = { RTE_CRYPTO_CIPHER_OP_ENCRYPT, RTE_CRYPTO_CIPHER_AES_CBC,
+	{.cipher = { RTE_CRYPTO_CIPHER_OP_ENCRYPT, RTE_CRYPTO_CIPHER_AES_CBC,
 		.key = { cipher_key, 16 } }
+	}
 };
 
 const struct rte_crypto_sym_xform aescbc_dec_xf = {
 	NULL,
 	RTE_CRYPTO_SYM_XFORM_CIPHER,
-	.cipher = { RTE_CRYPTO_CIPHER_OP_DECRYPT, RTE_CRYPTO_CIPHER_AES_CBC,
+	{.cipher = { RTE_CRYPTO_CIPHER_OP_DECRYPT, RTE_CRYPTO_CIPHER_AES_CBC,
 		.key = { cipher_key, 16 } }
+	}
 };
 
 static uint8_t auth_key[256] = "twentybytes hash key";
@@ -226,28 +228,32 @@ static uint8_t auth_key[256] = "twentybytes hash key";
 const struct rte_crypto_sym_xform sha1hmac_gen_xf = {
 	NULL,
 	RTE_CRYPTO_SYM_XFORM_AUTH,
-	.auth = { RTE_CRYPTO_AUTH_OP_GENERATE, RTE_CRYPTO_AUTH_SHA1_HMAC,
+	{.auth = { RTE_CRYPTO_AUTH_OP_GENERATE, RTE_CRYPTO_AUTH_SHA1_HMAC,
 		.key = { auth_key, 20 }, 12, 0 }
+	}
 };
 
 const struct rte_crypto_sym_xform sha1hmac_verify_xf = {
 	NULL,
 	RTE_CRYPTO_SYM_XFORM_AUTH,
-	.auth = { RTE_CRYPTO_AUTH_OP_VERIFY, RTE_CRYPTO_AUTH_SHA1_HMAC,
+	{.auth = { RTE_CRYPTO_AUTH_OP_VERIFY, RTE_CRYPTO_AUTH_SHA1_HMAC,
 		.key = { auth_key, 20 }, 12, 0 }
+	}
 };
 
 /* AES CBC xform */
 const struct rte_crypto_sym_xform null_cipher_xf = {
 	NULL,
 	RTE_CRYPTO_SYM_XFORM_CIPHER,
-	.cipher = { .algo = RTE_CRYPTO_CIPHER_NULL }
+	{.cipher = { .algo = RTE_CRYPTO_CIPHER_NULL }
+	}
 };
 
 const struct rte_crypto_sym_xform null_auth_xf = {
 	NULL,
 	RTE_CRYPTO_SYM_XFORM_AUTH,
-	.auth = { .algo = RTE_CRYPTO_AUTH_NULL }
+	{.auth = { .algo = RTE_CRYPTO_AUTH_NULL }
+	}
 };
 
 struct sa_ctx {
-- 
2.5.5

             reply	other threads:[~2016-04-08 17:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-08 17:01 Pablo de Lara [this message]
2016-04-08 20:19 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1460134869-42603-1-git-send-email-pablo.de.lara.guarch@intel.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=dev@dpdk.org \
    --cc=sergio.gonzalez.monroy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).