* [dpdk-dev] [PATCH] app/testpmd: fix strcat can overrun fixed-size string
@ 2016-04-11 16:03 Tomasz Kulasek
2016-04-27 15:01 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Tomasz Kulasek @ 2016-04-11 16:03 UTC (permalink / raw)
To: dev
CID 13307 (#1 of 1): Copy into fixed size buffer (STRING_OVERFLOW)
fixed_size_dest: You might overrun the 128 byte fixed-size string fwd_modes
by copying fwd_eng->fwd_mode_name without checking the length.
Fixes: 769ce6b17835 ("app/testpmd: list forwarding engines")
Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
---
app/test-pmd/config.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index b1bbec6..fff2d96 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -1673,8 +1673,10 @@ list_pkt_forwarding_modes(void)
if (strlen (fwd_modes) == 0) {
while ((fwd_eng = fwd_engines[i++]) != NULL) {
- strcat(fwd_modes, fwd_eng->fwd_mode_name);
- strcat(fwd_modes, separator);
+ strncat(fwd_modes, fwd_eng->fwd_mode_name, sizeof(fwd_modes) -
+ strlen(fwd_modes) - 1);
+ strncat(fwd_modes, separator, sizeof(fwd_modes) - strlen(fwd_modes)
+ - 1);
}
fwd_modes[strlen(fwd_modes) - strlen(separator)] = '\0';
}
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: fix strcat can overrun fixed-size string
2016-04-11 16:03 [dpdk-dev] [PATCH] app/testpmd: fix strcat can overrun fixed-size string Tomasz Kulasek
@ 2016-04-27 15:01 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2016-04-27 15:01 UTC (permalink / raw)
To: Tomasz Kulasek; +Cc: dev
2016-04-11 18:03, Tomasz Kulasek:
> CID 13307 (#1 of 1): Copy into fixed size buffer (STRING_OVERFLOW)
> fixed_size_dest: You might overrun the 128 byte fixed-size string fwd_modes
> by copying fwd_eng->fwd_mode_name without checking the length.
>
> Fixes: 769ce6b17835 ("app/testpmd: list forwarding engines")
>
> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-27 15:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-11 16:03 [dpdk-dev] [PATCH] app/testpmd: fix strcat can overrun fixed-size string Tomasz Kulasek
2016-04-27 15:01 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).