From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id EC7D2567E for ; Wed, 20 Apr 2016 13:44:32 +0200 (CEST) Received: by mail-wm0-f53.google.com with SMTP id e201so47235496wme.0 for ; Wed, 20 Apr 2016 04:44:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=guQSxnA0Z7TM4DtdgNtvJeKri6kkx0bF8hWVsy1fQ6s=; b=N9b+ej9l+meW2qyaT67LkWVZ8BkLu23aRTvphZecdN0m/b1wNcgjonHDMhviacH776 yhTdOiFBCmaZzGKi5Av0Sm7iK4zis6yhBexLQWVk17EPbjii71NcXeGpvtVZGnmTCTTl tCy7NNgHhACpZHCTd3A45RReaiC6ZrVf4gVeCxZCN0vqwHEjeJ3KPzTQv8qWT9m5dRYi iyv4TbMGUDEIJxskzp4TSgy9FkbwhHNhbKN2EiKPvdi9VcAgvy5nEmM8rUigC86UA9c6 FFPm1ve+8lQGJgvezAgPTL4tW40zLOspLO1Kn9D2urCOgmX8h3hvpSrlDyAlkB4n1Xbx V13Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=guQSxnA0Z7TM4DtdgNtvJeKri6kkx0bF8hWVsy1fQ6s=; b=aA3GHcd9VwnIWmYp2DZ6YLempTnbZfXAuYIXLbp1pFb8rbd/FY7/8vtvvH4OqJn1QL f3rOjSYjGsz/ZrIF636/hh0pRz3WTuKw+PhZsgcPeT8RUHGzDsgPNaUHHzzm6ywb7EXR IOk7x4mzxGx3Sm8Pzqo/yWKw3ORwzYh8wKcc/1Qj2iOyhiKQeZZtJcxu3oE91wN5bl9a S+gpON31H37h4xPUsm3KLSAP3r0L1nZVGsVzHe+N8iYJ57bgJ0oMoSrz/SGIFq1i2VR9 x2kMNOaPprgJK52x53pNtstHkE0COTcwQgVoSfG15d4zrSeMqVV+h9d9K0CQk5jnP3BX VSBw== X-Gm-Message-State: AOPr4FV+MdkeeMxeMiOZztZnCwnBAkbUW39y0xogGTlDJx8jA4iK7Fm5+WgV7ELca5JFpQl8 X-Received: by 10.28.32.199 with SMTP id g190mr31010376wmg.62.1461152672772; Wed, 20 Apr 2016 04:44:32 -0700 (PDT) Received: from gloops.dev.6wind.com (144.77.126.78.rev.sfr.net. [78.126.77.144]) by smtp.gmail.com with ESMTPSA id m6sm5195708wje.21.2016.04.20.04.44.31 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 20 Apr 2016 04:44:32 -0700 (PDT) From: David Marchand To: dev@dpdk.org Cc: thomas.monjalon@6wind.com, viktorin@rehivetech.com Date: Wed, 20 Apr 2016 13:44:10 +0200 Message-Id: <1461152657-19969-11-git-send-email-david.marchand@6wind.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1461152657-19969-1-git-send-email-david.marchand@6wind.com> References: <1454076516-21591-1-git-send-email-david.marchand@6wind.com> <1461152657-19969-1-git-send-email-david.marchand@6wind.com> Subject: [dpdk-dev] [PATCH v2 10/17] ethdev: get rid of eth driver register callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2016 11:44:33 -0000 Now that all pdev are pci drivers, we don't need to register ethdev drivers through a dedicated channel. Signed-off-by: David Marchand --- lib/librte_ether/rte_ethdev.c | 22 ---------------------- lib/librte_ether/rte_ethdev.h | 12 ------------ lib/librte_ether/rte_ether_version.map | 1 - 3 files changed, 35 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 7b908a7..7ec8cdb 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -334,28 +334,6 @@ rte_eth_dev_pci_remove(struct rte_pci_device *pci_dev) return 0; } -/** - * Register an Ethernet [Poll Mode] driver. - * - * Function invoked by the initialization function of an Ethernet driver - * to simultaneously register itself as a PCI driver and as an Ethernet - * Poll Mode Driver. - * Invokes the rte_eal_pci_register() function to register the *pci_drv* - * structure embedded in the *eth_drv* structure, after having stored the - * address of the rte_eth_dev_init() function in the *devinit* field of - * the *pci_drv* structure. - * During the PCI probing phase, the rte_eth_dev_init() function is - * invoked for each PCI [Ethernet device] matching the embedded PCI - * identifiers provided by the driver. - */ -void -rte_eth_driver_register(struct eth_driver *eth_drv) -{ - eth_drv->pci_drv.devinit = rte_eth_dev_pci_probe; - eth_drv->pci_drv.devuninit = rte_eth_dev_pci_remove; - rte_eal_pci_register(ð_drv->pci_drv); -} - int rte_eth_dev_is_valid_port(uint8_t port_id) { diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index 7a7a69e..016ce33 100644 --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librte_ether/rte_ethdev.h @@ -1868,18 +1868,6 @@ struct eth_driver { }; /** - * @internal - * A function invoked by the initialization function of an Ethernet driver - * to simultaneously register itself as a PCI driver and as an Ethernet - * Poll Mode Driver (PMD). - * - * @param eth_drv - * The pointer to the *eth_driver* structure associated with - * the Ethernet driver. - */ -void rte_eth_driver_register(struct eth_driver *eth_drv); - -/** * Convert a numerical speed in Mbps to a bitmap flag that can be used in * the bitmap link_speeds of the struct rte_eth_conf * diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map index 31017d4..d457b21 100644 --- a/lib/librte_ether/rte_ether_version.map +++ b/lib/librte_ether/rte_ether_version.map @@ -80,7 +80,6 @@ DPDK_2.2 { rte_eth_dev_vlan_filter; rte_eth_dev_wd_timeout_store; rte_eth_dma_zone_reserve; - rte_eth_driver_register; rte_eth_led_off; rte_eth_led_on; rte_eth_link; -- 1.9.1