From: Helin Zhang <helin.zhang@intel.com>
To: dev@dpdk.org
Cc: Helin Zhang <helin.zhang@intel.com>
Subject: [dpdk-dev] [PATCH 3/6] i40e: fix problematic dereference
Date: Thu, 21 Apr 2016 11:42:54 +0800 [thread overview]
Message-ID: <1461210177-29330-4-git-send-email-helin.zhang@intel.com> (raw)
In-Reply-To: <1461210177-29330-1-git-send-email-helin.zhang@intel.com>
Fix issue reported by Coverity.
Coverity ID 13294: Dereference before null check.
Fixes: a778a1fa2e4e ("i40e: set up and initialize flow director")
Signed-off-by: Helin Zhang <helin.zhang@intel.com>
---
drivers/net/i40e/i40e_rxtx.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index 31bfc44..4fd96fe 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e/i40e_rxtx.c
@@ -2981,13 +2981,15 @@ i40e_fdir_setup_tx_resources(struct i40e_pf *pf)
struct i40e_tx_queue *txq;
const struct rte_memzone *tz = NULL;
uint32_t ring_size;
- struct rte_eth_dev *dev = pf->adapter->eth_dev;
+ struct rte_eth_dev *dev;
if (!pf) {
PMD_DRV_LOG(ERR, "PF is not available");
return I40E_ERR_BAD_PTR;
}
+ dev = pf->adapter->eth_dev;
+
/* Allocate the TX queue data structure. */
txq = rte_zmalloc_socket("i40e fdir tx queue",
sizeof(struct i40e_tx_queue),
--
2.5.0
next prev parent reply other threads:[~2016-04-21 3:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 3:42 [dpdk-dev] [PATCH 0/6] fix i40e " Helin Zhang
2016-04-21 3:42 ` [dpdk-dev] [PATCH 1/6] i40e: fix " Helin Zhang
2016-04-21 16:10 ` Stephen Hemminger
2016-04-22 1:04 ` Zhang, Helin
2016-04-21 3:42 ` [dpdk-dev] [PATCH 2/6] " Helin Zhang
2016-04-21 3:42 ` Helin Zhang [this message]
2016-04-21 3:42 ` [dpdk-dev] [PATCH 4/6] " Helin Zhang
2016-04-21 3:42 ` [dpdk-dev] [PATCH 5/6] " Helin Zhang
2016-04-21 3:42 ` [dpdk-dev] [PATCH 6/6] " Helin Zhang
2016-04-21 10:06 ` [dpdk-dev] [PATCH 0/6] fix i40e " Thomas Monjalon
2016-04-21 12:49 ` Zhang, Helin
2016-04-21 12:51 ` Thomas Monjalon
2016-04-21 11:01 ` Bruce Richardson
2016-04-21 12:50 ` Zhang, Helin
2016-04-25 5:44 ` [dpdk-dev] [PATCH v2] i40e: fix " Helin Zhang
2016-04-25 9:41 ` Bruce Richardson
2016-04-28 3:17 ` [dpdk-dev] [PATCH v3 0/2] fix Coverity reported issues Helin Zhang
2016-04-28 3:17 ` [dpdk-dev] [PATCH v3 1/2] i40e: fix problematic dereference Helin Zhang
2016-04-28 3:17 ` [dpdk-dev] [PATCH v3 2/2] i40e: fix missing break in switch Helin Zhang
2016-06-26 15:46 ` [dpdk-dev] [PATCH v2 0/2] fix coverity issues Helin Zhang
2016-06-26 15:46 ` [dpdk-dev] [PATCH v2 1/2] i40e: fix problematic dereference Helin Zhang
2016-06-26 20:04 ` Mcnamara, John
2016-06-26 15:46 ` [dpdk-dev] [PATCH v2 2/2] i40e: fix missing break in switch Helin Zhang
2016-06-26 20:04 ` Mcnamara, John
2016-06-28 12:01 ` [dpdk-dev] [PATCH v2 0/2] fix coverity issues Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461210177-29330-4-git-send-email-helin.zhang@intel.com \
--to=helin.zhang@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).