DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v2] examples/qos_meter: fix unchecked return value
@ 2016-04-21 11:47 Michal Jastrzebski
  2016-04-21 11:47 ` [dpdk-dev] [PATCH v2] examples/qos_sched: fix out-of-bounds read Michal Jastrzebski
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Michal Jastrzebski @ 2016-04-21 11:47 UTC (permalink / raw)
  To: cristian.dumitrescu, roy.fan.zhang, jasvinder.singh
  Cc: dev, Slawomir Mrozowicz

From: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>

Fix issue reported by Coverity.

Coverity ID 30693: Unchecked return value
check_return: Calling rte_meter_srtcm_config without checking return value.

Fixes: e6541fdec8b2 ("meter: initial import")

Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
---
 examples/qos_meter/main.c | 15 ++++++++++-----
 examples/qos_meter/main.h |  2 +-
 2 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/examples/qos_meter/main.c b/examples/qos_meter/main.c
index b968b00..16b0b87 100644
--- a/examples/qos_meter/main.c
+++ b/examples/qos_meter/main.c
@@ -133,14 +133,17 @@ struct rte_meter_trtcm_params app_trtcm_params[] = {
 
 FLOW_METER app_flows[APP_FLOWS_MAX];
 
-static void
+static int
 app_configure_flow_table(void)
 {
 	uint32_t i, j;
+	int ret = 0;
 
-	for (i = 0, j = 0; i < APP_FLOWS_MAX; i ++, j = (j + 1) % RTE_DIM(PARAMS)){
-		FUNC_CONFIG(&app_flows[i], &PARAMS[j]);
-	}
+	for (i = 0, j = 0; i < APP_FLOWS_MAX;
+			i ++, j = (j + 1) % RTE_DIM(PARAMS))
+		ret |= FUNC_CONFIG(&app_flows[i], &PARAMS[j]);
+
+	return ret;
 }
 
 static inline void
@@ -381,7 +384,9 @@ main(int argc, char **argv)
 	rte_eth_promiscuous_enable(port_tx);
 
 	/* App configuration */
-	app_configure_flow_table();
+	ret = app_configure_flow_table();
+	if (ret < 0)
+		rte_exit(EXIT_FAILURE, "Invalid configure flow table\n");
 
 	/* Launch per-lcore init on every lcore */
 	rte_eal_mp_remote_launch(main_loop, NULL, CALL_MASTER);
diff --git a/examples/qos_meter/main.h b/examples/qos_meter/main.h
index 530bf69..54867dc 100644
--- a/examples/qos_meter/main.h
+++ b/examples/qos_meter/main.h
@@ -51,7 +51,7 @@ enum policer_action policer_table[e_RTE_METER_COLORS][e_RTE_METER_COLORS] =
 #if APP_MODE == APP_MODE_FWD
 
 #define FUNC_METER(a,b,c,d) color, flow_id=flow_id, pkt_len=pkt_len, time=time
-#define FUNC_CONFIG(a,b)
+#define FUNC_CONFIG(a, b) 0
 #define PARAMS	app_srtcm_params
 #define FLOW_METER int
 
-- 
1.9.1

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2016-05-16 15:35 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-21 11:47 [dpdk-dev] [PATCH v2] examples/qos_meter: fix unchecked return value Michal Jastrzebski
2016-04-21 11:47 ` [dpdk-dev] [PATCH v2] examples/qos_sched: fix out-of-bounds read Michal Jastrzebski
2016-04-28 10:59   ` Dumitrescu, Cristian
2016-05-16 15:35     ` Thomas Monjalon
     [not found] ` <1461239256-8104-3-git-send-email-michalx.k.jastrzebski@intel.com>
2016-04-28 10:58   ` [dpdk-dev] [PATCH v2] examples/qos_sched: fix copy-paste error Dumitrescu, Cristian
     [not found] ` <1461239256-8104-4-git-send-email-michalx.k.jastrzebski@intel.com>
2016-04-28 10:58   ` [dpdk-dev] [PATCH v2] examples/qos_sched: fix negative loop bound Dumitrescu, Cristian
2016-04-28 11:22 ` [dpdk-dev] [PATCH v2] examples/qos_meter: fix unchecked return value Dumitrescu, Cristian

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).