From: Michal Jastrzebski <michalx.k.jastrzebski@intel.com>
To: cristian.dumitrescu@intel.com, roy.fan.zhang@intel.com,
jasvinder.singh@intel.com
Cc: dev@dpdk.org, Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
Subject: [dpdk-dev] [PATCH v3] examples/qos_sched: fix negative loop bound
Date: Thu, 21 Apr 2016 15:08:11 +0200 [thread overview]
Message-ID: <1461244093-2008-1-git-send-email-michalx.k.jastrzebski@intel.com> (raw)
From: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
Fix issue reported by Coverity.
Coverity ID 30704: Negative loop bound
negative_returns: Using unsigned variable n_tokens in a loop exit condition.
Fixes: de3cfa2c9823 ("sched: initial import")
Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
---
examples/qos_sched/args.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c
index 3e7fd08..7a98e5c 100644
--- a/examples/qos_sched/args.c
+++ b/examples/qos_sched/args.c
@@ -162,7 +162,7 @@ static int
app_parse_opt_vals(const char *conf_str, char separator, uint32_t n_vals, uint32_t *opt_vals)
{
char *string;
- uint32_t i, n_tokens;
+ int i, n_tokens;
char *tokens[MAX_OPT_VALUES];
if (conf_str == NULL || opt_vals == NULL || n_vals == 0 || n_vals > MAX_OPT_VALUES)
--
1.9.1
next reply other threads:[~2016-04-21 13:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 13:08 Michal Jastrzebski [this message]
2016-04-21 13:08 ` [dpdk-dev] [PATCH v3] examples/qos_sched: fix copy-paste error Michal Jastrzebski
2016-04-28 11:00 ` Dumitrescu, Cristian
2016-05-16 16:16 ` Thomas Monjalon
2016-04-21 13:08 ` [dpdk-dev] [PATCH v3] examples/qos_sched: fix bad bit shift operation Michal Jastrzebski
2016-04-28 11:16 ` Dumitrescu, Cristian
2016-05-10 9:39 ` Mrozowicz, SlawomirX
2016-05-10 9:45 ` Dumitrescu, Cristian
2016-04-28 10:59 ` [dpdk-dev] [PATCH v3] examples/qos_sched: fix negative loop bound Dumitrescu, Cristian
2016-05-16 16:02 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461244093-2008-1-git-send-email-michalx.k.jastrzebski@intel.com \
--to=michalx.k.jastrzebski@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=roy.fan.zhang@intel.com \
--cc=slawomirx.mrozowicz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).