From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
by dpdk.org (Postfix) with ESMTP id C3C69595A
for <dev@dpdk.org>; Tue, 3 May 2016 00:22:40 +0200 (CEST)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
by fmsmga104.fm.intel.com with ESMTP; 02 May 2016 15:22:23 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,569,1455004800"; d="scan'208";a="95911195"
Received: from yliu-dev.sh.intel.com ([10.239.67.162])
by fmsmga004.fm.intel.com with ESMTP; 02 May 2016 15:22:22 -0700
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: dev@dpdk.org
Cc: huawei.xie@intel.com, Thomas Monjalon <thomas.monjalon@6wind.com>,
Panu Matilainen <pmatilai@redhat.com>, Tetsuya Mukawa <mukawa@igel.co.jp>,
Traynor Kevin <kevin.traynor@intel.com>,
Yuanhan Liu <yuanhan.liu@linux.intel.com>
Date: Mon, 2 May 2016 15:25:23 -0700
Message-Id: <1462227927-22853-13-git-send-email-yuanhan.liu@linux.intel.com>
X-Mailer: git-send-email 1.9.0
In-Reply-To: <1462227927-22853-1-git-send-email-yuanhan.liu@linux.intel.com>
References: <1462227927-22853-1-git-send-email-yuanhan.liu@linux.intel.com>
Subject: [dpdk-dev] [PATCH 12/16] vhost: remove unnecessary fields
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 02 May 2016 22:22:41 -0000
The "reserved" field in virtio_net and vhost_virtqueue struct is not
necessary any more. We now expose virtio_net device with a number "vid".
This patch also removes the "priv" field: all fields are priviate now:
application can't access it now. The only way that we could still access
it is to expose it by a function, but I doubt that's needed or worthwhile.
Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
---
lib/librte_vhost/vhost-net.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/lib/librte_vhost/vhost-net.h b/lib/librte_vhost/vhost-net.h
index dad0280..2e4c95d 100644
--- a/lib/librte_vhost/vhost-net.h
+++ b/lib/librte_vhost/vhost-net.h
@@ -82,7 +82,6 @@ struct vhost_virtqueue {
/* Physical address of used ring, for logging */
uint64_t log_guest_addr;
- uint64_t reserved[15];
struct buf_vector buf_vec[BUF_VECTOR_MAX];
} __rte_cache_aligned;
@@ -127,14 +126,12 @@ struct virtio_net {
#define IF_NAME_SZ (PATH_MAX > IFNAMSIZ ? PATH_MAX : IFNAMSIZ)
char ifname[IF_NAME_SZ];
uint32_t virt_qp_nb;
- void *priv;
uint64_t log_size;
uint64_t log_base;
struct ether_addr mac;
/* to tell if we need broadcast rarp packet */
rte_atomic16_t broadcast_rarp;
- uint64_t reserved[61];
struct vhost_virtqueue *virtqueue[VHOST_MAX_QUEUE_PAIRS * 2];
} __rte_cache_aligned;
--
1.9.0