DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Vadim Suraev <vadim.suraev@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] timer bug fix.
Date: Mon, 26 May 2014 18:25:49 +0200	[thread overview]
Message-ID: <1462523.elkQdoiaBG@xps13> (raw)
In-Reply-To: <537F5EC8.70109@6wind.com>

> > Bug: When a timer is running
> > 
> >   - if rte_timer_stop is called, the pending decrement is
> >   skipped (decremented only if the timer is pending) and due
> >   to the update flag the future processing is skipped so the
> >   timer is counted as pending while it is stopped. - the same
> >   applies when rte_timer_reset is called but then the pending
> >   statistics is additionally incremented so the timer is
> >   counted pending twice.
> > 
> > Solution: decrement the pending
> > 
> >   statistics after returning from the callback. If
> >   rte_timer_stop was called, it skipped decrementing the
> >   pending statistics. If rte_time_reset was called, the
> >   pending statistics was incremented. If neither was called
> >   and the timer is periodic, the pending statistics is
> >   incremented when it is reloaded
> > 
> > Signed-off-by: Vadim Suraev <vadim.suraev@gmail.com>
> 
> Acked-by: Olivier Matz <olivier.matz@6wind.com>

Applied for version 1.7.0 with title:
	timer: fix pending counter

Thanks
-- 
Thomas

  reply	other threads:[~2014-05-26 16:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-21 20:35 Vadim Suraev
2014-05-23 14:44 ` Olivier MATZ
2014-05-26 16:25   ` Thomas Monjalon [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-05-21 19:53 Vadim Suraev
2014-05-23 14:52 ` Olivier MATZ
2014-05-26 16:24   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1462523.elkQdoiaBG@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=vadim.suraev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).