From: Ziye Yang <ziye.yang@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] librte_eal: fix wrong args operation in eal_parse_args
Date: Wed, 11 May 2016 13:28:21 +0800 [thread overview]
Message-ID: <1462944501-15852-1-git-send-email-ziye.yang@intel.com> (raw)
This patch is used to fix wrong operation on user
input args. eal_parse_args function should not operate
the args passed by the user. If the element in argv
is generated by malloc function, changing it will cause
memory issues when free the args.
Signed-off-by: Ziye Yang <ziye.yang@intel.com>
---
lib/librte_eal/bsdapp/eal/eal.c | 2 --
lib/librte_eal/linuxapp/eal/eal.c | 2 --
2 files changed, 4 deletions(-)
diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c
index 06bfd4e..0eef92d 100644
--- a/lib/librte_eal/bsdapp/eal/eal.c
+++ b/lib/librte_eal/bsdapp/eal/eal.c
@@ -420,8 +420,6 @@ eal_parse_args(int argc, char **argv)
goto out;
}
- if (optind >= 0)
- argv[optind-1] = prgname;
ret = optind-1;
out:
diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
index 8aafd51..ba9d1ac 100644
--- a/lib/librte_eal/linuxapp/eal/eal.c
+++ b/lib/librte_eal/linuxapp/eal/eal.c
@@ -658,8 +658,6 @@ eal_parse_args(int argc, char **argv)
goto out;
}
- if (optind >= 0)
- argv[optind-1] = prgname;
ret = optind-1;
out:
--
1.9.3
next reply other threads:[~2016-05-11 5:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 5:28 Ziye Yang [this message]
2016-05-11 11:24 ` Bruce Richardson
2016-05-11 11:51 ` Yang, Ziye
2016-05-11 12:21 ` Richardson, Bruce
2016-05-11 13:39 ` Yang, Ziye
2016-05-11 14:07 ` Richardson, Bruce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462944501-15852-1-git-send-email-ziye.yang@intel.com \
--to=ziye.yang@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).