From: zr@semihalf.com
To: remy.horton@intel.com
Cc: dev@dpdk.org, Zyta Szpak <zyta.szpak@semihalf.com>,
Zyta Szpak <zr@semihalf.com>
Subject: [dpdk-dev] [PATCH] examples/ethtool: include case for 64-bit registers
Date: Wed, 11 May 2016 12:48:34 +0200 [thread overview]
Message-ID: <1462963714-21022-1-git-send-email-zr@semihalf.com> (raw)
From: Zyta Szpak <zyta.szpak@semihalf.com>
rte_eth_dev_get_reg_length and rte_eth_dev_get_reg callbacks
do not provide register size to the app in any way. Example assuming
they are 32-bit wide always allocates not enough memory if the
registers are 64-bit wide. It results in memory corruption.
This commit is a quick fix to make enough room for 64-bit
register values when this returned value is given to malloc.
Signed-off-by: Zyta Szpak <zr@semihalf.com>
---
examples/ethtool/lib/rte_ethtool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/ethtool/lib/rte_ethtool.c b/examples/ethtool/lib/rte_ethtool.c
index 42e05f1..bf0a6ac 100644
--- a/examples/ethtool/lib/rte_ethtool.c
+++ b/examples/ethtool/lib/rte_ethtool.c
@@ -91,7 +91,7 @@ rte_ethtool_get_regs_len(uint8_t port_id)
count_regs = rte_eth_dev_get_reg_length(port_id);
if (count_regs > 0)
- return count_regs * sizeof(uint32_t);
+ return count_regs * sizeof(uint64_t);
return count_regs;
}
--
1.9.1
next reply other threads:[~2016-05-11 10:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 10:48 zr [this message]
2016-05-20 8:25 ` Remy Horton
2016-05-23 5:11 ` Zyta Szpak
2016-05-25 6:36 ` [dpdk-dev] [PATCH 1/2] ethdev: add callback to get register size in bytes zr
2016-05-25 6:36 ` [dpdk-dev] [PATCH 2/2] examples/ethtool: get reg width to allocate memory zr
2016-05-25 13:14 ` Remy Horton
2016-05-25 13:14 ` [dpdk-dev] [PATCH 1/2] ethdev: add callback to get register size in bytes Remy Horton
2016-05-30 9:00 ` Zyta Szpak
2016-05-27 10:28 ` Panu Matilainen
2016-05-27 14:43 ` Thomas Monjalon
2016-05-30 9:32 ` Zyta Szpak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462963714-21022-1-git-send-email-zr@semihalf.com \
--to=zr@semihalf.com \
--cc=dev@dpdk.org \
--cc=remy.horton@intel.com \
--cc=zyta.szpak@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).