DPDK patches and discussions
 help / color / mirror / Atom feed
From: Alex Wang <ee07b291@gmail.com>
To: dev@dpdk.org
Cc: ferruh.yigit@intel.com, Alex Wang <alex@awakenetworks.com>
Subject: [dpdk-dev] [PATCH 2/2 v3] kni: add documentation for the mempool capacity
Date: Sat, 21 May 2016 00:58:36 -0700	[thread overview]
Message-ID: <1463817516-1752-2-git-send-email-ee07b291@gmail.com> (raw)
In-Reply-To: <1463817516-1752-1-git-send-email-ee07b291@gmail.com>

From: Alex Wang <alex@awakenetworks.com>

Function like 'rte_kni_rx_burst()' keeps
allocating 'MAX_MBUF_BURST_NUM' mbufs to
kni fifo queue unless the queue's capacity
('KNI_FIFO_COUNT_MAX') is reached.  So, if
the mempool is under-provisioned, user may
run into "Out of Memory" logs from KNI code.
This commit documents the need to provision
mempool capacity of more than
"2 x KNI_FIFO_COUNT_MAX" for each KNI interface.

Signed-off-by: Alex Wang <alex@awakenetworks.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 lib/librte_kni/rte_kni.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/librte_kni/rte_kni.h b/lib/librte_kni/rte_kni.h
index 25fa45e..ac11148 100644
--- a/lib/librte_kni/rte_kni.h
+++ b/lib/librte_kni/rte_kni.h
@@ -113,6 +113,9 @@ extern void rte_kni_init(unsigned int max_kni_ifaces);
  * The rte_kni_alloc shall not be called before rte_kni_init() has been
  * called. rte_kni_alloc is thread safe.
  *
+ * The mempool should have capacity of more than "2 x KNI_FIFO_COUNT_MAX"
+ * elements for each KNI interface allocated.
+ *
  * @param pktmbuf_pool
  *  The mempool for allocting mbufs for packets.
  * @param conf
-- 
2.1.4

  reply	other threads:[~2016-05-23 17:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-21  7:58 [dpdk-dev] [PATCH 1/2 v3] kni: fix inverted function comments Alex Wang
2016-05-21  7:58 ` Alex Wang [this message]
2016-06-09 12:03   ` [dpdk-dev] [PATCH 2/2 v3] kni: add documentation for the mempool capacity Mcnamara, John
2016-06-09 17:06     ` Alex Wang
2016-06-09 17:10       ` Mcnamara, John
2016-06-14 15:16     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1463817516-1752-2-git-send-email-ee07b291@gmail.com \
    --to=ee07b291@gmail.com \
    --cc=alex@awakenetworks.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).