From: Huawei Xie <huawei.xie@intel.com>
To: dev@dpdk.org
Cc: stephen@networkplumber.org, konstantin.ananyev@intel.com,
thomas.monjalon@6wind.com, Huawei Xie <huawei.xie@intel.com>
Subject: [dpdk-dev] [PATCH] virtio: use volatile to get used->idx in the loop
Date: Wed, 25 May 2016 00:16:41 +0800 [thread overview]
Message-ID: <1464106601-981-1-git-send-email-huawei.xie@intel.com> (raw)
There is no external function call or any barrier in the loop,
the used->idx would only be retrieved once.
Signed-off-by: Huawei Xie <huawei.xie@intel.com>
---
drivers/net/virtio/virtio_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index c3fb628..f6d6305 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -204,7 +204,8 @@ virtio_send_command(struct virtqueue *vq, struct virtio_pmd_ctrl *ctrl,
usleep(100);
}
- while (vq->vq_used_cons_idx != vq->vq_ring.used->idx) {
+ while (vq->vq_used_cons_idx !=
+ *((volatile uint16_t *)(&vq->vq_ring.used->idx))) {
uint32_t idx, desc_idx, used_idx;
struct vring_used_elem *uep;
--
1.8.1.4
next reply other threads:[~2016-05-25 8:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 16:16 Huawei Xie [this message]
2016-05-25 8:25 ` Xie, Huawei
2016-05-25 8:34 ` Michael S. Tsirkin
2016-05-25 9:47 ` Bruce Richardson
2016-05-25 9:50 ` Michael S. Tsirkin
2016-05-25 10:00 ` Bruce Richardson
2016-05-25 15:24 ` Xie, Huawei
2016-05-30 8:22 ` Yuanhan Liu
2016-06-01 5:40 ` Xie, Huawei
2016-06-01 6:05 ` Yuanhan Liu
2016-06-02 8:39 ` Xie, Huawei
2016-06-02 8:52 ` Yuanhan Liu
2016-06-02 8:54 ` Xie, Huawei
2016-06-14 13:23 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464106601-981-1-git-send-email-huawei.xie@intel.com \
--to=huawei.xie@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=stephen@networkplumber.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).