From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f181.google.com (mail-we0-f181.google.com [74.125.82.181]) by dpdk.org (Postfix) with ESMTP id 113845907 for ; Tue, 24 Jun 2014 11:21:59 +0200 (CEST) Received: by mail-we0-f181.google.com with SMTP id q59so7722wes.40 for ; Tue, 24 Jun 2014 02:22:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=o0Biyzxvqqq/ZqwGhl4C9DhpqgsqiJ6ubEdeZq/qCgE=; b=OIxez9o5eh8F8GDmH4b2Y/VQiw0XomffUtmanOFGKbEY+ibklt7WmlKV0lU5FkkCme AFMROkKuy4RFCv873TYO8mrm/UyIvmYwr1MZy2bvVTi3TWCYukpY1bIdbUisiCzCf04I Q7RqZlNVKbMGCc+raQrsnA6qRyDSD+jhguxeKkgEFc3lUyPJhxAx4NYU70GprUf+Bqhw M3VF9y1M13sZUIh8LzO0dEGpfk53J65FCEEn8Mp8PiyH5QOFBo1IJlbvvoDDOJjIwFnI ThoaCfKaXK3d6YOWzM+VHlsN+L1lqD4BlLJiFjneY6/C/phuFu2VqWo5lRbcon33sxJz 9KHA== X-Gm-Message-State: ALoCoQn8bElHEeH1Tdi24nN1SNbUacMoxgqK7hXJ0k+ps5VZss239zGdPlwL87hcARzMGsmQKcZL X-Received: by 10.195.17.164 with SMTP id gf4mr34425176wjd.45.1403601737267; Tue, 24 Jun 2014 02:22:17 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id ja9sm41473640wic.8.2014.06.24.02.22.15 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Jun 2014 02:22:16 -0700 (PDT) From: Thomas Monjalon To: "Richardson, Bruce" Date: Tue, 24 Jun 2014 11:22:12 +0200 Message-ID: <1464235.EKIaBTSv1Q@xps13> Organization: 6WIND User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; ) In-Reply-To: <59AF69C657FD0841A61C55336867B5B02CEE1C5C@IRSMSX103.ger.corp.intel.com> References: <20140623101603.54a5d887@nehalam.linuxnetplumber.net> <59AF69C657FD0841A61C55336867B5B02CEE1C5C@IRSMSX103.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] Why rte_snprintf at all? X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jun 2014 09:21:59 -0000 2014-06-23 22:53, Richardson, Bruce: > As for the #define, it's a quick fix, except that we end up having to keep > it forever as the code using the function will never get changed to use > rte_snprintf. Given it's just a one-line macro, it's probably not a big > deal in this case, but I'd rather see us take the approach that after > something has been flagged as deprecated for a certain amount of time e.g. > 1 to 2 full release cycles, it is removed completely and deleted. Otherwise > I worry about us having to maintain a bunch of stuff for legacy reasons, > that really should be got rid of. We should not just remove something > completely in a single release, but I think we need to have a way to remove > things completely once the user has been given sufficient warning. I agree. -- Thomas