From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 13A87591F for ; Fri, 27 May 2016 14:06:24 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 27 May 2016 05:06:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,373,1459839600"; d="scan'208";a="709793364" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by FMSMGA003.fm.intel.com with ESMTP; 27 May 2016 05:06:23 -0700 Received: from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com [10.237.217.46]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id u4RC6Lgd010518; Fri, 27 May 2016 13:06:21 +0100 Received: from sivswdev02.ir.intel.com (localhost [127.0.0.1]) by sivswdev02.ir.intel.com with ESMTP id u4RC6LKx000761; Fri, 27 May 2016 13:06:21 +0100 Received: (from reshmapa@localhost) by sivswdev02.ir.intel.com with id u4RC6Leg000757; Fri, 27 May 2016 13:06:21 +0100 From: Reshma Pattan To: dev@dpdk.org Cc: Reshma Pattan Date: Fri, 27 May 2016 13:06:20 +0100 Message-Id: <1464350780-724-1-git-send-email-reshma.pattan@intel.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1464269755-26123-1-git-send-email-reshma.pattan@intel.com> References: <1464269755-26123-1-git-send-email-reshma.pattan@intel.com> Subject: [dpdk-dev] [PATCH v2] pcap: fix segfault in pcap pmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 May 2016 12:06:25 -0000 Testpmd application will crash in fclose() upon quit after running the below command. "sudo gdb --args ./x86_64-native-linuxapp-gcc/app/testpmd -c 0xf0 -n 4 --vdev 'eth_pcap0,tx_iface=enp1s0f1,rx_pcap=/tmp/test.pcap' -- --port-topology=chained -i" The reason is, pcap vdev creation with tx stream type as "iface" as in above command don't need member ''dumpers'' of "struct tx_pcaps", hence will not have memory allocated. But contains a garbage values, as local object of struct tx_pcaps is not initialized to 0 inside rte_pmd_pcap_dev_init(). So calling pcap_dump_close() on dumper as part of eth_dev_stop() is causing segfault in fclose(). Fix is to initialize local object of struct tx_pcaps to 0. Also initialize local object of struct rx_pcaps to 0. So during eth_dev_stop(), pcap_dump_close() will not be called if dumper is NULL. Fixes:4c173302("pcap: add new driver") Signed-off-by: Reshma Pattan Acked-by: Ferruh Yigit --- v2: Fixed typos in commit message. Fixed commit message line length to 75. Fixed subject line of the patch. --- drivers/net/pcap/rte_eth_pcap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index c98e234..c86f17b 100644 --- a/drivers/net/pcap/rte_eth_pcap.c +++ b/drivers/net/pcap/rte_eth_pcap.c @@ -978,8 +978,8 @@ rte_pmd_pcap_devinit(const char *name, const char *params) unsigned numa_node, using_dumpers = 0; int ret; struct rte_kvargs *kvlist; - struct rx_pcaps pcaps; - struct tx_pcaps dumpers; + struct rx_pcaps pcaps = {0}; + struct tx_pcaps dumpers = {0}; RTE_LOG(INFO, PMD, "Initializing pmd_pcap for %s\n", name); -- 2.5.0